-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gameboy memory callback values #3904
Draft
roydmerkel
wants to merge
38
commits into
TASEmulators:master
Choose a base branch
from
roydmerkel:add-gameboy-memory-callback-values
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
a1b70e2
Added debug value callbacks for sameboy and gambette.
roydmerkel 2bc81d0
temporarily changed gambette version to temporary checkout with value…
roydmerkel aa7700e
Temporarily committed sameboy and gambette dlls.
roydmerkel 66af7b0
Merge branch 'add-gameboy-memory-callback-values' of https://github.c…
roydmerkel 1157d6c
Merge pull request #2 from roydmerkel/master
roydmerkel 7fd697f
Made sure newest version of sameboy was being used.
roydmerkel 06a3b38
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 1751407
Updated libsameboy module.
roydmerkel 84f4a5c
Merge branch 'master' into add-gameboy-memory-callback-values
roydmerkel bf64dd0
Fixed bsnes build
roydmerkel 65a6183
Merge pull request #3 from roydmerkel/fix-bsnes-build
roydmerkel 626db79
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel b4c8d61
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 130f0f7
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel bf75ab8
Added methods of getting mapper and bank for bsnes sgb and bsnes 115+…
roydmerkel ac61c26
Updated dlls.
roydmerkel 8c523f1
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 8d721de
Performance optimizations by moving bank register pulls to separate f…
roydmerkel dd0d821
Merge branch 'add-gameboy-memory-callback-values' of https://github.c…
roydmerkel 6eda8c8
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 89a40a9
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel dab869f
Updated bsnes dll.
roydmerkel 13aa266
reverted removal of Gambette bank registers from registers call, and …
roydmerkel 6566b47
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 58e309d
updated to upstream master for libsameboy.
roydmerkel 11232d5
Merge branch 'add-gameboy-memory-callback-values' of https://github.c…
roydmerkel 22ad5e5
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 0213628
Review comment: move bank registers back into registers list (was ori…
roydmerkel e489d1b
Review comment: reverted bsnes changes.
roydmerkel ca88b56
Updated gambette and sameboy .dll files after syncing sameboy against…
roydmerkel 566c397
Merge branch 'add-gameboy-memory-callback-values' of https://github.c…
roydmerkel 6311d2d
Merge pull request #4 from roydmerkel/master
roydmerkel c670022
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 317e915
Rolled back libsnes changes since libsnes does not support memory or …
roydmerkel 1af6619
Updated libsameboy to 0.16.6
roydmerkel 170af1e
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel f38aef5
Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-v…
roydmerkel 4fcb6b6
Rebuilt gambatte using ucrt to fix seg faults in my rig and rebuild l…
roydmerkel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule gambatte
updated
2 files
+1 −1 | libgambatte/include/gambatte.h | |
+5 −5 | libgambatte/src/memory.h |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule libsameboy
updated
78 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? And is it part of the BANK register changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having issues with GBHawk requiring memory mapped buffer to match a 0x10000 size, so it was excepting incorrectly. It is unrelated to banking code, I'll revert that part and fix separately as part of a separate change.