Fix calculation of STIX pointing in HPC to imaging demo #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 68.92% 69.52% +0.60%
==========================================
Files 31 31
Lines 1847 1887 +40
==========================================
+ Hits 1273 1312 +39
- Misses 574 575 +1 ☔ View full report in Codecov by Sentry. |
samaloney
approved these changes
May 9, 2024
| @@ -129,7 +129,7 @@ | |||
| header = make_fitswcs_header(bp_image, coord, telescope='STIX', observatory='Solar Orbiter', scale=[10,10]*u.arcsec/u.pix) | |||
| fd_bp_map = Map((bp_image, header)) | |||
|
|
|||
| hpc_ref = Helioprojective(pointing[0], pointing[1], observer=solo, obstime=fd_bp_map.date) | |||
There was a problem hiding this comment.
Good catch - I think this was done but must have been lost at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects how the HPC coordinate of the centre of the STIX pointing is calculated in the imaging demo. While the pre-existing calculation is approximately valid in the demo's case, it is not valid for substanital roll angle. The approach given in the PR should be valid for all roll angles.