Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation of STIX pointing in HPC to imaging demo #112

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix calculation of STIX pointing in HPC to imaging demo #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ef4e4
Add correct calculation of STIX pointing in HPC to imaging demo.
DanRyanIrish May 9, 2024
fc8a436
Add changelog for PR 112.
DanRyanIrish May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/112.doc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Correct calculation of the HPC coordinate of the center of the STIX pointing in the imaging demo.
2 changes: 1 addition & 1 deletion examples/imaging_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
header = make_fitswcs_header(bp_image, coord, telescope='STIX', observatory='Solar Orbiter', scale=[10,10]*u.arcsec/u.pix)
fd_bp_map = Map((bp_image, header))

hpc_ref = Helioprojective(pointing[0], pointing[1], observer=solo, obstime=fd_bp_map.date)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - I think this was done but must have been lost at some point.

hpc_ref = coord.transform_to(Helioprojective(observer=solo, obstime=fd_bp_map.date)) # Center of STIX pointing in HPC
header_hp = make_fitswcs_header(bp_image, hpc_ref, scale=[10, 10]*u.arcsec/u.pix, rotation_angle=90*u.deg+roll)
hp_map = Map((bp_image, header_hp))
hp_map_rotated = hp_map.rotate()
Expand Down
Loading