Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Create SQL Logic for Get User Actions #12136

Merged
merged 23 commits into from
Mar 5, 2023
Merged

[#12048] Create SQL Logic for Get User Actions #12136

merged 23 commits into from
Mar 5, 2023

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Feb 25, 2023 •
edited
Loading

Part of #12048.

Outline of Solution

This PR has the following changes:

  • Add db and user logic for get instructor and student
  • Add unit and integration tests
  • Update related entities

@domlimm domlimm force-pushed the v9-get-instructor-student-actions branch 2 times, most recently from 305d286 to 24200ea Compare February 26, 2023 10:52
@domlimm domlimm changed the title Create SQL Logic for Get Instructor and Student Actions [#12048] Create SQL Logic for Get Instructor and Student Actions Feb 27, 2023
@domlimm domlimm force-pushed the v9-get-instructor-student-actions branch from 06c3ec5 to 590ea0b Compare February 27, 2023 03:05
@samuelfangjw samuelfangjw force-pushed the v9-get-instructor-student-actions branch from 4eafa0c to e0dd403 Compare March 1, 2023 20:33
@domlimm domlimm force-pushed the v9-get-instructor-student-actions branch from e0dd403 to 542996d Compare March 2, 2023 17:59
@domlimm domlimm marked this pull request as ready for review March 2, 2023 18:32
@domlimm domlimm mentioned this pull request Mar 4, 2023
Merged
samuelfangjw
samuelfangjw approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@samuelfangjw samuelfangjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues with unit tests, will be resolved at a later time.

@samuelfangjw samuelfangjw changed the title [#12048] Create SQL Logic for Get Instructor and Student Actions [#12048] Create SQL Logic for Get User Actions Mar 5, 2023
@samuelfangjw samuelfangjw merged commit 6636362 into TEAMMATES:v9-migration Mar 5, 2023
samuelfangjw pushed a commit that referenced this pull request Apr 8, 2023
@domlimm @samuelfangjw
[#12048] Create SQL Logic for Get User Actions (#12136)
8adeed8
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelfangjw samuelfangjw samuelfangjw approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@domlimm @samuelfangjw @wkurniawan07