Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Add Unit Tests for UserDb methods #12163

Merged
merged 29 commits into from
Mar 5, 2023
Merged

[#12048] Add Unit Tests for UserDb methods #12163

merged 29 commits into from
Mar 5, 2023

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Mar 4, 2023 •
edited
Loading

Part of #12048.

Outline of Solution

Rebased on v9-get-instructor-student-actions of PR #12136.

This PR consists of the following changes:

  • Added unit tests to CRUD methods for User

domlimm and others added 29 commits March 3, 2023 01:57
@domlimm
Add get instructor and student actions
b62fdc4
@domlimm
Prioritise entity in method's docs
587ce2e
@domlimm
Remove get current session method from related get methods
0c4db35
@domlimm
Add unit tests
5bf9330
@domlimm
Fix checkstyle and pmd problems
561c095
@domlimm
Remove get current session method
d49cb82
@domlimm
Add integration tests
2176c2b
@domlimm
Fix checkstyle and pmd errors
fc397e4
@domlimm
Fix error with wrong data type on role
e64b8a1
@domlimm
Update IT for get instructor
a6ed1cb
@domlimm
Update check existing instructor
6ee5b0d
@domlimm
Add attempt to fix instructor IT
3d66f61
@samuelfangjw @domlimm
Fix users db integration test
abf96c0
@domlimm
Update team attribute in entities
057fb5d
@domlimm
Update unit tests for get
03d5971
@domlimm
Add IT for get student
82e74a2
@domlimm
Fix checkstyle and pmd errors
542996d
@domlimm
Fix errors with UUID and clean up
c7f7b2c
@domlimm
Fix pmd overridden error by using parent's setup method
cc7c596
@domlimm
Fix architecture tests by using parent test class assert equals method
126684b
@domlimm
Remove setter, clean up unit and integration tests
f89ca5c
@domlimm
Remove explicit assignment of course id
c4e2b36
@domlimm
Update access modifier to curb with calls from UTs
4cd591c
@domlimm
Adjust access modifier to match suggestion by IDE
cd586b8
@domlimm
Rename method for clarity
6167606
@domlimm
Add unit tests for CRUD methods
3c063f5
@domlimm
Refactor empty user delete UT
40f6cd0
@samuelfangjw
Merge branch 'v9-migration' into v9-instructor-student-db-unit-tests
6fdb823
@samuelfangjw
Fix issues
4291c58
@samuelfangjw samuelfangjw changed the title [#12048] Add Unit Tests for CRUD methods [#12048] Add Unit Tests for UserDb methods Mar 5, 2023
@samuelfangjw samuelfangjw merged commit cad0def into TEAMMATES:v9-migration Mar 5, 2023
@domlimm
Copy link
Contributor Author

domlimm commented Mar 5, 2023

@samuelfangjw samuel, noted on all the changes you've added. thank you for making them and cleaning up!

samuelfangjw pushed a commit that referenced this pull request Apr 8, 2023
@domlimm @samuelfangjw
[#12048] Add Unit Tests for UserDb methods (#12163)
a66ce42
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@domlimm @wkurniawan07 @samuelfangjw