StudentFeedbackResultsPage: separate self-responses from others' responses #8497 #8690
Conversation
| @@ -179,7 +179,7 @@ private FeedbackResultsResponseTable createResponseTable(FeedbackQuestionAttribu | |||
| if (question.giverType == FeedbackParticipantType.TEAMS && isUserPartOfGiverTeam) { | |||
| displayedGiverName = "Your Team (" + giverName + ")"; | |||
| } else if (isUserGiver) { | |||
| displayedGiverName = "You"; | |||
| displayedGiverName = "(Your own response)"; | |||
There was a problem hiding this comment.
I don't think From: (Your own response) makes sense when displayed in the UI. From: Yourself might make more sense?
There was a problem hiding this comment.
Good points. Actually I've just noticed a new pull request created today offers a better solution to this issue #6290 so this pull request can be closed now.
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <c:choose> | |||
| <c:when test="${responseTable.giverNameYou}"> | |||
There was a problem hiding this comment.
This check does not cover all cases. For instance, in the screenshot below, the response that is immediately relevant to the student is grayed out while responses that are intended for others are in blue (blue implied as the more relevant color).
You may want to consider the possible permutations of senders and receivers of a response, and decide which ones you think a student may find relevant.
craaaa
added
s.Ongoing
|
Closing this PR as work on #8700 covers a similar purview. However, I think that a separate issue #8690 touches on is ensuring that responses directed at the student (i.e. |
Fixes #8497
Outline of Solution
Change of text to help distinguish between our own feedback responses, and those from our teammates.
Bootstrap change to the color of the panel for our own responses.