Student: view session results: do not show self responses #6290 #8700
Conversation
…f two types of responses
…showing-self-responses
|
Status: ongoing |
|
Status: Ready for review |
There was a problem hiding this comment.
Great work so far - the changes that you have made look nice :). However, I am not quite sure if you want to put all your own responses in a separate section like this, after the other responses.
This is because doing so may lead students to:
(i) mistakenly believe that they did not submit their responses successfully
(ii) miss out on instructor feedback
To understand this better, consider the example feedback responses below (from a student's perspective):
Here, the current design can lead students to:
(i) Mistakenly believe that they did not submit their responses successfully
These questions are not targetted at a particular student/team, but are the student’s own reflection. By splitting the responses into two distinct subsections like what you have done, students will have to scroll all the way down to see their responses again. Consequently, students might misunderstand and think that they did not manage to submit their responses successfully etc.
(ii) Miss out on instructor feedback
Furthermore, such questions allow for feedback from the instructor. This means that students can receive feedback like this:
but under this design the student might potentially miss out instructor feedback as it is buried at the end of the page.
Lastly, the page also becomes needlessly long because of the duplicate questions. This is especially so if the survey has many self-feedback questions (like the example above).
As such, I am more for an approach like this:
@damithc @xpdavid @craaaa @dalessr What are your thoughts on this?
|
|
||
| <c:set value="panel-primary" var="panelHeaderClass"/> | ||
|
|
||
| <div class="panel ${panelHeaderClass}"> |
There was a problem hiding this comment.
Why not just do <div class="panel panel-primary"> directly since self response tables have now been separated from others response tables?
|
|
||
| <c:set value="panel-default" var="panelHeaderClass"/> | ||
|
|
||
| <div class="panel ${panelHeaderClass}"> |
There was a problem hiding this comment.
Same here as well - why not just use panel-default directly?
| <span class="text-muted"> | ||
| From: AHPUiT Instrúctör WithPlusInEmail [Tue, 01 May 2012, 05:36 AM UTC+0800] | ||
| From: AHPUiT Instrúctör WithPlusInEmail [Tue, 01 May 2012, 05:39 AM UTC+0800] |
There was a problem hiding this comment.
Eh, why did the time change?
| <tbody> | ||
| <c:forEach items="${othersResponseTable.responses}" var="othersResponse"> | ||
| <feedbackResults:othersResponse othersResponse="${othersResponse}"/> | ||
| </c:forEach> |
There was a problem hiding this comment.
The <c: block should be indented one level further :P Because of this your HTML files have more changes than necessary as well.
| @@ -378,7 +464,7 @@ <h4> | |||
| <a href="/"> | |||
| TEAMMATES | |||
| </a> | |||
| V${version}] | |||
| V6.0.0] | |||
There was a problem hiding this comment.
Also, things like these probably shouldn't be changed :P
|
Actually I don't think the original display of feedback result looks confusing to students... And if we separate others responses and self responses, then there is a higher chance that some questions are displayed without any response below. In this case, only showing the question is not suitable, but skipping the question is also not suitable. The color of the panels actually does not matter since we separate them into two parts, which is clear enough. The mockup proposed by @joanneong looks nice. It emphasizes the own responses for each question, which is clear enough for students. But is it a bit redundant to have "Your own response" for every question? Would like to hear the others' suggestions @damithc @xpdavid |
|
@dalessr I prefer @joanneong 's suggestion actually (A side note: @dalessr, to save ur time and also not to waste your effort, next time please discuss your solution (if the solution is not straight forward) under the issue before u are sending PR). Even we can collapse the tab. BTW, if we are talking about |
I'm OK with the approach proposed by @joanneong |
dalessr
deleted the
6290-student-view-session-results-without-showing-self-responses
branch
Fixes #6290
Outline of Solution
Your own responseFeedbackResponseTablesinto two groups, one group with feedback giver asYouand the other with giver asOthersCurrent:
See whether this looks clearer and less confusing to students!