-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] TSFE can be initialized for pages with fe_group="-2" #3352
Merged
dkd-kaehm
merged 2 commits into
TYPO3-Solr:main
from
dkd-kaehm:bugfix/3351_fe_groups_-2
Oct 13, 2023
Merged
[TEST] TSFE can be initialized for pages with fe_group="-2" #3352
dkd-kaehm
merged 2 commits into
TYPO3-Solr:main
from
dkd-kaehm:bugfix/3351_fe_groups_-2
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
added
help wanted
Priority: High
Used by Solr-Core team to prioritize (Pull-Requests are welcome)
labels
Sep 23, 2022
dkd-kaehm
force-pushed
the
bugfix/3351_fe_groups_-2
branch
from
February 3, 2023 18:48
1452afe
to
62fd8e6
Compare
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Oct 11, 2023
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, whichs fe_group is set to -2(show if fe_user is logged in). This leads to following behavior: * After editing the [sub]pages in BE, the page is removed from index and never indexed again. * By reinitialization of pages index queue the page is indexed as expected with expected groups. Fixes: TYPO3-Solr#3351 Relates: TYPO3-Solr#3347 Ports: TYPO3-Solr#3352
dkd-kaehm
force-pushed
the
bugfix/3351_fe_groups_-2
branch
4 times, most recently
from
October 13, 2023 16:35
3313a72
to
9da29e1
Compare
dkd-kaehm
changed the title
[BUGFIX] TSFE can not be initialized for pages with fe_group="-2"
[TEST] TSFE can not be initialized for pages with fe_group="-2"
Oct 13, 2023
dkd-kaehm
force-pushed
the
bugfix/3351_fe_groups_-2
branch
from
October 13, 2023 19:09
72f9ad2
to
8f2549c
Compare
The TSFE must be initializable in record-monitoring(BE editiing) context for pages, whichs fe_group is set to -2(show if fe_user is logged in). This leads to following behavior: * After editing the [sub]pages in BE, the page is removed from index and never indexed again. * By reinitialization of pages index queue the page is indexed as expected with expected groups. Relates: TYPO3-Solr#3351, TYPO3-Solr#3347
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
dkd-kaehm
force-pushed
the
bugfix/3351_fe_groups_-2
branch
from
October 13, 2023 21:39
8f2549c
to
1b6a1dd
Compare
dkd-kaehm
changed the title
[TEST] TSFE can not be initialized for pages with fe_group="-2"
[TEST] TSFE can be initialized for pages with fe_group="-2"
Oct 13, 2023
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 6, 2023
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, whichs fe_group is set to -2(show if fe_user is logged in). This leads to following behavior: * After editing the [sub]pages in BE, the page is removed from index and never indexed again. * By reinitialization of pages index queue the page is indexed as expected with expected groups. Fixes: TYPO3-Solr#3351 Relates: TYPO3-Solr#3347 Ports: TYPO3-Solr#3352
dkd-friedrich
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Feb 23, 2024
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, whichs fe_group is set to -2(show if fe_user is logged in). This leads to following behavior: * After editing the [sub]pages in BE, the page is removed from index and never indexed again. * By reinitialization of pages index queue the page is indexed as expected with expected groups. Fixes: TYPO3-Solr#3351 Relates: TYPO3-Solr#3347 Ports: TYPO3-Solr#3352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, whichs fe_group is set to -2(show if fe_user is logged in).
This leads to following behavior:
Relates: #3347, #3351
Ported from: #3819
This bug is not present on TYPO3 12.4.7 + EXT:solr bbdda0c, so the test only will be merged. The fix for EXT:solr 11.5+ will be done within #3819
The indexing of pages with fe_group=-2 / "show at any login" was broken in 12.0.0(RC1), which is fixed in this pr.