Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] TSFE can be initialized for pages with fe_group="-2" #3352

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

dkd-kaehm
Copy link
Collaborator

@dkd-kaehm dkd-kaehm commented Sep 23, 2022

The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, whichs fe_group is set to -2(show if fe_user is logged in).

This leads to following behavior:

  • After editing the [sub]pages in BE, the page is removed from index and never indexed again.
  • By reinitialization of pages index queue the page is indexed as expected with expected groups.

Relates: #3347, #3351
Ported from: #3819


This bug is not present on TYPO3 12.4.7 + EXT:solr bbdda0c, so the test only will be merged. The fix for EXT:solr 11.5+ will be done within #3819

The indexing of pages with fe_group=-2 / "show at any login" was broken in 12.0.0(RC1), which is fixed in this pr.

@dkd-kaehm dkd-kaehm added help wanted Priority: High Used by Solr-Core team to prioritize (Pull-Requests are welcome) labels Sep 23, 2022
@dkd-kaehm dkd-kaehm changed the base branch from main to release-11.5.x October 11, 2023 08:07
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 11, 2023
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, 
whichs fe_group is set to -2(show if fe_user is logged in).

This leads to following behavior:
* After editing the [sub]pages in BE, the page is removed from index and never indexed again.
* By reinitialization of pages index queue the page is indexed as expected with expected groups.

Fixes: TYPO3-Solr#3351
Relates: TYPO3-Solr#3347
Ports: TYPO3-Solr#3352
@dkd-kaehm dkd-kaehm changed the base branch from release-11.5.x to main October 11, 2023 08:12
@dkd-kaehm dkd-kaehm force-pushed the bugfix/3351_fe_groups_-2 branch 4 times, most recently from 3313a72 to 9da29e1 Compare October 13, 2023 16:35
@dkd-kaehm dkd-kaehm changed the title [BUGFIX] TSFE can not be initialized for pages with fe_group="-2" [TEST] TSFE can not be initialized for pages with fe_group="-2" Oct 13, 2023
The TSFE must be initializable in record-monitoring(BE editiing) context for pages, 
whichs fe_group is set to -2(show if fe_user is logged in).

This leads to following behavior:
* After editing the [sub]pages in BE, the page is removed from index and never indexed again.
* By reinitialization of pages index queue the page is indexed as expected with expected groups.

Relates: TYPO3-Solr#3351, TYPO3-Solr#3347
@dkd-kaehm dkd-kaehm changed the title [TEST] TSFE can not be initialized for pages with fe_group="-2" [TEST] TSFE can be initialized for pages with fe_group="-2" Oct 13, 2023
@dkd-kaehm dkd-kaehm merged commit 6118788 into TYPO3-Solr:main Oct 13, 2023
1 check failed
@dkd-kaehm dkd-kaehm deleted the bugfix/3351_fe_groups_-2 branch October 13, 2023 21:40
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 6, 2023
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, 
whichs fe_group is set to -2(show if fe_user is logged in).

This leads to following behavior:
* After editing the [sub]pages in BE, the page is removed from index and never indexed again.
* By reinitialization of pages index queue the page is indexed as expected with expected groups.

Fixes: TYPO3-Solr#3351
Relates: TYPO3-Solr#3347
Ports: TYPO3-Solr#3352
dkd-friedrich pushed a commit to dkd-kaehm/ext-solr that referenced this pull request Feb 23, 2024
The TSFE can not be initialized in record-monitoring(BE editiing) context for pages, 
whichs fe_group is set to -2(show if fe_user is logged in).

This leads to following behavior:
* After editing the [sub]pages in BE, the page is removed from index and never indexed again.
* By reinitialization of pages index queue the page is indexed as expected with expected groups.

Fixes: TYPO3-Solr#3351
Relates: TYPO3-Solr#3347
Ports: TYPO3-Solr#3352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Priority: High Used by Solr-Core team to prioritize (Pull-Requests are welcome)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant