Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 컨벤션 및 세팅 수정 #146

Closed
4 tasks done
mcrkgus opened this issue Aug 4, 2024 · 0 comments · Fixed by #147
Closed
4 tasks done

[Fix] 컨벤션 및 세팅 수정 #146

mcrkgus opened this issue Aug 4, 2024 · 0 comments · Fixed by #147
Assignees
@mcrkgus
Labels
💞 가현 가현 공주 작업 🛠️ Fix 버그, 오류 해결

Comments

@mcrkgus
Copy link
Member

mcrkgus commented Aug 4, 2024 •
edited
Loading

🛠 Issue

  • 변경된 컨벤션을 재적용
  • 세팅 수정

📝 To-do

  • Stringliterals
  • Protocol파일 제거
  • Image, Font Literals 파일 제거
  • make rounded extension 매개변수 통일
@mcrkgus mcrkgus added ⚙️ Setting 프로젝트 설정관련 🔧 Chore Feat 이외에 코드 수정, 내부 파일 수정, 애매한 것들이나 잡일 💞 가현 가현 공주 작업 labels Aug 4, 2024
@mcrkgus mcrkgus self-assigned this Aug 4, 2024
@mcrkgus mcrkgus changed the title [Chore] 컨벤션 및 세팅 수정 [] 컨벤션 및 세팅 수정 Aug 4, 2024
@mcrkgus mcrkgus changed the title [] 컨벤션 및 세팅 수정 [Fix] 컨벤션 및 세팅 수정 Aug 4, 2024
@mcrkgus mcrkgus added 🛠️ Fix 버그, 오류 해결 and removed ⚙️ Setting 프로젝트 설정관련 🔧 Chore Feat 이외에 코드 수정, 내부 파일 수정, 애매한 것들이나 잡일 labels Aug 4, 2024
mcrkgus added a commit that referenced this issue Aug 4, 2024
@mcrkgus
[Add] #146 - StringLiterals 추가
80e5f52
mcrkgus added a commit that referenced this issue Aug 4, 2024
@mcrkgus
[Chore] #146 - StringLiterals 적용
dd3cecc
mcrkgus added a commit that referenced this issue Aug 4, 2024
@mcrkgus
[Del] #146 - 사용하지 않는 파일 제거
1a53e6c
mcrkgus added a commit that referenced this issue Aug 4, 2024
@mcrkgus
[Chore] #146 - makeRoundBorder 속성 통일
5f02b01
mcrkgus added a commit that referenced this issue Aug 4, 2024
@mcrkgus
[Chore] #146 - makeRoundBorder 반영
4a6bae3
@mcrkgus mcrkgus mentioned this issue Aug 4, 2024
Merged
3 tasks
mcrkgus added a commit that referenced this issue Aug 5, 2024
@mcrkgus
[Merge] #147 - 컨벤션 및 세팅 수정
38b8d84 
[Fix] #146 - 컨벤션 및 세팅 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcrkgus mcrkgus

Labels
💞 가현 가현 공주 작업 🛠️ Fix 버그, 오류 해결
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] #146 - 컨벤션 및 세팅 수정 Team-Hankki/hankki-iOS
1 participant
@mcrkgus