Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #146 - 컨벤션 및 세팅 수정 #147

Merged
merged 5 commits into from
Aug 5, 2024
Merged

[Fix] #146 - 컨벤션 및 세팅 수정 #147

merged 5 commits into from
Aug 5, 2024

Conversation

mcrkgus
Copy link
Member

@mcrkgus mcrkgus commented Aug 4, 2024

🔥 Pull requests

👷 작업한 내용

  • 변경된 컨벤션을 다시 적용함
  • Stringliterals
  • Protocol파일 제거
  • Image, Font Literals 파일 제거
  • make rounded extension 매개변수 통일

🖥️ 주요 코드 설명

UIView+

  • UIView를 상속 받는 모든 컴포넌트에 적용이 가능합니다.
    /// UIView 의 모서리의 색상, 모서리 두께, 둥근 정도
    func makeRoundBorder(cornerRadius: CGFloat, borderWidth: CGFloat, borderColor: UIColor ) {
        layer.masksToBounds = true
        layer.cornerRadius = cornerRadius
        layer.borderWidth = borderWidth
        layer.borderColor = borderColor.cgColor
    }
    

✅ Check List

  • Merge 대상 브랜치가 올바른가?
  • 최종 코드가 에러 없이 잘 동작하는가?
  • 전체 변경사항이 500줄을 넘지 않는가?

📟 관련 이슈

@mcrkgus mcrkgus added 🛠️ Fix 버그, 오류 해결 💞 가현 가현 공주 작업 labels Aug 4, 2024
@mcrkgus mcrkgus self-assigned this Aug 4, 2024
Copy link
Contributor

@shimseohyun shimseohyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하였사옵니다.

Comment on lines 8 to +25
import Foundation

enum StringLiterals {
enum Home {
static let storeCategoryFilteringButton = "종류"
static let priceFilteringButton = "가격대"
static let sortFilteringButton = "정렬"
static let less6000 = "6000원 이하"
static let more6000 = "6000~8000원"
static let won = "원"
}

enum Alert {
static let unknownError = "알 수 없는 오류가 발생했어요"
static let tryAgain = "네트워크 연결 상태를 확인하고\n다시 시도해주세요"
static let check = "확인"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주굿

static let sortFilteringButton = "정렬"
static let less6000 = "6000원 이하"
static let more6000 = "6000~8000원"
static let won = "원"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3 소인 아뢰옵기 황송하오나, 이러한 정말 고정적인 내용은 아예 Common으로 빼는것이 어떻겠나이까. 소인도 이러한 문자를 사용해야하옵니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원 말인가유??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소인이 읽기로는 enum Home 말고 enum Common 과 같은 걸로 빼달라는 이야기 같소이다.

Copy link
Member

@EunsuSeo01 EunsuSeo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨소이다.

static let sortFilteringButton = "정렬"
static let less6000 = "6000원 이하"
static let more6000 = "6000~8000원"
static let won = "원"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소인이 읽기로는 enum Home 말고 enum Common 과 같은 걸로 빼달라는 이야기 같소이다.

@mcrkgus mcrkgus merged commit 38b8d84 into develop Aug 5, 2024
@mcrkgus mcrkgus deleted the fix/#146 branch August 5, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💞 가현 가현 공주 작업 🛠️ Fix 버그, 오류 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 컨벤션 및 세팅 수정
3 participants