Update to .NET 7

[benaadams]

/cc @sebastienros

[sebastienros]

@roji do you want to do the db changes in a separate PR?
@EgorBo this PR contains <TieredPGO> and also envs in the docker file. Which option should we use for best throughput?

[benaadams]

@EgorBo this PR contains <TieredPGO> and also envs in the docker file. Which option should we use for best throughput?

Shouldn't really matter both the same; .csproj is the more current way of doing it, and didn't feel like taking it out of 20 docker files 😅

[EgorBo]

@roji do you want to do the db changes in a separate PR? @EgorBo this PR contains <TieredPGO> and also envs in the docker file. Which option should we use for best throughput?

I'd say for the best performance we also need DOTNET_ReadyToRun=0 that can't be defined via csproj. TieredPGO alone doesn't improve these benchmarks a lot because it can't instrumented R2R'd code of BCL and aspnet. We've fixed that in .NET 8.0 in dotnet/runtime#70941

But don't disable DOTNET_ReadyToRun if "time to first request" metric is important 🙂

[EgorBo]

Glad to see AsciiString is no more 🎉

[benaadams]

C# caught up 😉

[benaadams]

I'd say for the best performance we also need DOTNET_ReadyToRun=0 that can't be defined via csproj. TieredPGO alone doesn't improve these benchmarks a lot because it can't instrumented R2R'd code of BCL and aspnet. We've fixed that in .NET 8.0 in dotnet/runtime#70941

Already there

[davidfowl]

@benaadams you can also improve

FrameworkBenchmarks/frameworks/CSharp/aspnetcore/PlatformBenchmarks/DateHeader.cs

Line 30 in bec2f23

var utf8 = Encoding.ASCII.GetBytes("\r\nDate: ").AsSpan();

to use utf8 string literals.

[roji]

@roji do you want to do the db changes in a separate PR?

@sebastienros sure, there's a bit work left on my side in any case (e.g. aspnet/Benchmarks#1764). Let's get this merged and I'll submit a separate database PR later.

[benaadams]

@benaadams you can also improve

👍

[MichalStrehovsky]

@benaadams if you can run:

$ curl -L https://github.com/TechEmpower/FrameworkBenchmarks/commit/b0a0c17aaa94ff2187018f59656f83e10cea4c11.patch | git am

It would add support for PublishAot. I have that one in a separate pull request (#7720) and the CI already ran on it. Or that pull request can wait until this one merges, whenever that is.

We can also delete frameworks/CSharp/aspnetcore-corert because it ran its course (and has actually been broken for a while because it uses .NET 7 with ASP.NET 6 and there was a breaking change in Quic APIs).

[benaadams]

@benaadams if you can run:

$ curl -L https://github.com/TechEmpower/FrameworkBenchmarks/commit/b0a0c17aaa94ff2187018f59656f83e10cea4c11.patch | git am

It would add support for PublishAot. I have that one in a separate pull request (#7720) and the CI already ran on it. Or that pull request can wait until this one merges, whenever that is.

We can also delete frameworks/CSharp/aspnetcore-corert because it ran its course (and has actually been broken for a while because it uses .NET 7 with ASP.NET 6 and there was a breaking change in Quic APIs).

Done and removed the corert framework; as suggested, since adding more variants that are equivalent

[MichalStrehovsky]

Thank you!

[benaadams]

NativeAOT is not currently supported for ASP.NET Core apps and thus this should not be marked as "Realistic".

Applied

[davidfowl]

@benaadams Can we change GetRequestType to use a switch expression on the path?

Ugh, it doesn't work with utf8 strings it seems

[NateBrady23]

@benaadams Let me know when this is ready!

[benaadams]

@benaadams Let me know when this is ready!

Is good to go now; will do follow up for other changes