Refactor: 重构 Slider 组件 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +955 B (0%) Total Size: 225 kB
ℹ️ View Unchanged
|
|
Size Change: +955 B (0%) Total Size: 225 kB
ℹ️ View Unchanged
|
Dengzygx
reviewed
May 17, 2022
src/slider/slider.vue
Outdated
| context.emit('change', value); | ||
| tmpValue.sort((a, b) => a - b); | ||
| setInnerValue(tmpValue); | ||
| // context.emit('update:modelValue', value); |
Dengzygx
reviewed
May 17, 2022
src/hooks/useVModel.ts
Outdated
| @@ -0,0 +1,51 @@ | |||
| import { ref, Ref, getCurrentInstance, ComponentInternalInstance } from 'vue'; | |||
There was a problem hiding this comment.
已经有了useVModel这个hook，在src/shared/useVModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
无
💡 需求背景和解决方案
重构 Slider 组件
📝 更新日志
feat: 支持新组件 Slider 滑动选择器
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单