Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/rate #642

Merged
merged 10 commits into from
May 17, 2023
Merged

Refactor/rate #642

merged 10 commits into from
May 17, 2023

Conversation

fengchunqi
Copy link
Contributor

@fengchunqi fengchunqi commented Apr 26, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

移动端 mobile-vue 发布正式版 #514

💡 需求背景和解决方案

📝 更新日志

  • break(Rate): 调整 DOM 结构

  • break(Rate): 移除 clearablevariant 属性

  • break(Rate): size 属性默认值变更为 24px

  • break(Rate): gap 属性默认值变更为 8

  • feat(Rate): 新增 icon 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 27, 2023

@fengchunqi

问题:

  1. 半选的时候,也需要支持一下点选哦
  2. 冲突了 😳

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

完成

@anlyyao anlyyao merged commit ab5bd3a into Tencent:develop May 17, 2023
LeeJim added a commit that referenced this pull request May 17, 2023
* feat(drawer): add new version

* Refactor/rate (#642)

* feat(Rate): update api

* refactor(rate): rate tips

* refactor(rate): rate tips

* refactor(rate): rate tips

* refactor(rate): rate

rate tips

* chore: update _common

* test: update snapshots

* fix(Rate): gap value is changed to 8

---------

Co-authored-by: anlyyao <[email protected]>

* fix(popup): add destroy-on-close property (#672)

* fix(popup): add destroy-on-hide property

* fix(popup): finish destroy-on-close

* feat(drawer): add new version

* fix(drawer): resolve ts error

* test(drawer): update snapshot

* test: update snapshot

* test: update snapshot

---------

Co-authored-by: chunqi feng <[email protected]>
Co-authored-by: anlyyao <[email protected]>
@github-actions github-actions bot mentioned this pull request May 23, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants