Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: 更新文件源接口只传id不传code时报错 #2414

Closed
jsonwan opened this issue Aug 31, 2023 · 2 comments
Closed

perf: 更新文件源接口只传id不传code时报错 #2414

jsonwan opened this issue Aug 31, 2023 · 2 comments
Assignees
@jsonwan @liuliaozhong
Labels
done 已上线到正式环境并验收通过 for test 可以在测试环境进行验收 kind/enhancement 功能改进特性

Comments

@jsonwan
Copy link
Collaborator

jsonwan commented Aug 31, 2023

出了什么问题？(What Happened?)
更新文件源接口只传id不传code时报内部服务器错误

如何复现？(How to reproduce?)
调用更新文件源ESB/APIGW接口，请求体只传id不传code，调用报500。

预期结果(What you expect?)
报400错误，并明确给出错误提示。
@jsonwan jsonwan added kind/enhancement 功能改进特性 backlog 需求初始状态，等待产品进行评估 labels Aug 31, 2023
@jsonwan jsonwan self-assigned this Aug 31, 2023
@jsonwan
Copy link
Collaborator Author

jsonwan commented Aug 31, 2023

  1. 补充参数校验；
  2. 修正文件源查询逻辑；
  3. 修正字段更新逻辑，null字段不更新。

@jsonwan
Copy link
Collaborator Author

jsonwan commented Oct 20, 2023

该接口只支持传code，id去掉（之前也是一直不生效的），文档里面已经更正过来了，如果没传code报400：文件源code不可为空

liuliaozhong added a commit to liuliaozhong/bk-job that referenced this issue Oct 23, 2023
@liuliaozhong
perf: 更新文件源接口只传id不传code时报错 TencentBlueKing#2414
7e1f2a6
liuliaozhong added a commit to liuliaozhong/bk-job that referenced this issue Oct 23, 2023
@liuliaozhong
perf: 更新文件源接口只传id不传code时报错 TencentBlueKing#2414
0490695
liuliaozhong added a commit to liuliaozhong/bk-job that referenced this issue Nov 24, 2023
@liuliaozhong
Merge pull request #10 from liuliaozhong/3.7.x_issue_2414
7c50e59 
perf: 更新文件源接口只传id不传code时报错 TencentBlueKing#2414
jsonwan added a commit that referenced this issue Dec 12, 2023
@jsonwan
Merge pull request #2537 from liuliaozhong/3.7.x_issue_2414
0531a44 
perf: 更新文件源接口只传id不传code时报错 #2414
@bkjob-bot bkjob-bot added for test 可以在测试环境进行验收 and removed backlog 需求初始状态，等待产品进行评估 labels Dec 20, 2023
@bkjob-bot bkjob-bot added for gray 可以在灰度环境/预发布环境验收 done 已上线到正式环境并验收通过 and removed for test 可以在测试环境进行验收 for gray 可以在灰度环境/预发布环境验收 labels Dec 28, 2023
@bkjob-bot bkjob-bot added the for test 可以在测试环境进行验收 label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsonwan jsonwan

@liuliaozhong liuliaozhong

Labels
done 已上线到正式环境并验收通过 for test 可以在测试环境进行验收 kind/enhancement 功能改进特性
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsonwan @bkjob-bot @liuliaozhong