perf: 更新文件源接口只传id不传code时报错 #2414 #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonwan
reviewed
Oct 23, 2023
| @@ -202,6 +202,7 @@ | |||
| 1260016=At least one of id/code required | |||
| 1260017=FileSource[id={0}] does not belong to specified business | |||
| 1260018=FileWorker response error, Detail:{0} | |||
| 1260019=File source code can not empty | |||
jsonwan
reviewed
Oct 23, 2023
| @@ -325,6 +325,8 @@ public class ErrorCode { | |||
| public static final int FILE_SOURCE_ID_NOT_IN_BIZ = 1260017; | |||
| // 接入点响应异常，详情：{0} | |||
| public static final int FAIL_TO_REQUEST_FILE_WORKER_WITH_REASON = 1260018; | |||
| // 文件源code不可为空 | |||
| public static final int FILE_SOURCE_CODE_NOT_EMPTY = 1260019; | |||
There was a problem hiding this comment.
名称含义不清晰，改为：FILE_SOURCE_CODE_CAN_NOT_BE_EMPTY
jsonwan
requested changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.