don't request sync on macOS app #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davep
approved these changes
Jan 25, 2023
darrenburns
reviewed
Jan 25, 2023
| @@ -146,8 +146,9 @@ def on_terminal_resize(signum, stack) -> None: | |||
| self._enable_bracketed_paste() | |||
|
|
|||
| def _request_terminal_sync_mode_support(self): | |||
| self.console.file.write("\033[?2026$p") | |||
| self.console.file.flush() | |||
| if self.console._environ.get("TERM_PROGRAM", "") != "Apple_Terminal": | |||
There was a problem hiding this comment.
Could you add a comment here saying why this code is here? It's the sort of thing someone else could look at 6 months from now and not understand.
There was a problem hiding this comment.
Yeah, fair enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1622
I think the terminal should ignore this escape sequence. It isn't so we will have to workaround it.