Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't request sync on macOS app #1664

Merged
merged 3 commits into from
Jan 25, 2023
Merged

don't request sync on macOS app #1664

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9caf0cf
don't request sync on macOS app
willmcgugan Jan 25, 2023
15af0cd
wrong env var
willmcgugan Jan 25, 2023
a292086
comment and docstring
willmcgugan Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/textual/drivers/linux_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ def on_terminal_resize(signum, stack) -> None:
self._enable_bracketed_paste()

def _request_terminal_sync_mode_support(self):
self.console.file.write("\033[?2026$p")
self.console.file.flush()
if self.console._environ.get("TERM_PROGRAM", "") != "Apple_Terminal":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here saying why this code is here? It's the sort of thing someone else could look at 6 months from now and not understand.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair enough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

self.console.file.write("\033[?2026$p")
self.console.file.flush()

@classmethod
def _patch_lflag(cls, attrs: int) -> int:
Expand Down