Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable labelling rows #1868

Merged
merged 34 commits into from
Feb 27, 2023
Merged

Datatable labelling rows #1868

merged 34 commits into from
Feb 27, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 23, 2023 •
edited
Loading

image

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns
Renaming some component classes in DataTable
4472100
@darrenburns
Some more renaming of DataTable component classes
28b1e4c
@darrenburns
Separate styling for fixed rows/columns from labels
50a8c79
@darrenburns
Highlight fixed rows/cols affected by colour differently
ba10906
@darrenburns
Tweaking styles for fixed data in DataTable
ea11eae
@darrenburns
Update DataTable snapshots
d2fe8b8
@darrenburns
Merge branch 'datatable-clearing-cache-fix' into datatable-labelling-…
2b06377 
…rows
@darrenburns
Merge branch 'datatable-cache-fix-performance-improvement' into datat…
af62a18 
…able-labelling-rows
@darrenburns
Add row label to Row metadata
fff7d8b
@darrenburns
Wiring up some labelled row logic behind flags
43ee713
@darrenburns
Renaming variable in DataTable
2160eca
@darrenburns
Variable renaming in DataTable
847161e
@darrenburns
[no ci] Labelling rows progress
de9989e
@darrenburns
Add RenderedRow abstraction to DataTable
fbbfbf8
@darrenburns
Computing label widths
5d42b24
@darrenburns
Use the Column object to represent row label column
a11ea77
@darrenburns
Ability to toggle row labels reactively
b19f5f4
@darrenburns
Adjust width calculation for label widths
724ccbc
@darrenburns
Add DataTable.RowLabelSelected
3260acb
@darrenburns
Posting the RowLabelClick message
9d5fe20
@darrenburns
Hovering of row labels applies new style
7759b66
@darrenburns
Remove a print
9aa3d6f
@darrenburns
Ensure horizontal scrolling with column cursor accounts for row label…
48b3252 
… column
@darrenburns
Account for possible row labels in cell cursor horizontal scrolling
06149b1
@darrenburns
Ensure cursor highlighting is correct on row label cells
93e6983
@darrenburns
Merge branch 'main' of github.com:Textualize/textual into datatable-l…
1cc7e40 
…abelling-rows
@darrenburns
Document component class for DataTable label hover
49b5d26
@darrenburns
Test to ensure clicking row label emits correct event
eb8672c
@darrenburns
Add snapshot test for DataTable with fixed rows/cols and row labels
18cb467
@darrenburns
Using pilot pause instead of wait_for_idle directly
af6c236
@darrenburns darrenburns marked this pull request as ready for review February 23, 2023 16:45
willmcgugan
willmcgugan approved these changes Feb 26, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks like a tricky bit of work.

@darrenburns darrenburns merged commit cbe2ab8 into main Feb 27, 2023
@darrenburns darrenburns deleted the datatable-labelling-rows branch February 27, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan