Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable labelling rows #1868

Merged
merged 34 commits into from
Feb 27, 2023
Merged

Datatable labelling rows #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4472100
Renaming some component classes in DataTable
darrenburns Feb 15, 2023
28b1e4c
Some more renaming of DataTable component classes
darrenburns Feb 15, 2023
50a8c79
Separate styling for fixed rows/columns from labels
darrenburns Feb 15, 2023
ba10906
Highlight fixed rows/cols affected by colour differently
darrenburns Feb 15, 2023
ea11eae
Tweaking styles for fixed data in DataTable
darrenburns Feb 15, 2023
d2fe8b8
Update DataTable snapshots
darrenburns Feb 15, 2023
2b06377
Merge branch 'datatable-clearing-cache-fix' into datatable-labelling-…
darrenburns Feb 16, 2023
af62a18
Merge branch 'datatable-cache-fix-performance-improvement' into datat…
darrenburns Feb 16, 2023
fff7d8b
Add row label to Row metadata
darrenburns Feb 16, 2023
43ee713
Wiring up some labelled row logic behind flags
darrenburns Feb 16, 2023
2160eca
Renaming variable in DataTable
darrenburns Feb 16, 2023
847161e
Variable renaming in DataTable
darrenburns Feb 16, 2023
de9989e
[no ci] Labelling rows progress
darrenburns Feb 16, 2023
fbbfbf8
Add RenderedRow abstraction to DataTable
darrenburns Feb 22, 2023
5d42b24
Computing label widths
darrenburns Feb 22, 2023
a11ea77
Use the Column object to represent row label column
darrenburns Feb 23, 2023
b19f5f4
Ability to toggle row labels reactively
darrenburns Feb 23, 2023
724ccbc
Adjust width calculation for label widths
darrenburns Feb 23, 2023
3260acb
Add DataTable.RowLabelSelected
darrenburns Feb 23, 2023
9d5fe20
Posting the RowLabelClick message
darrenburns Feb 23, 2023
7759b66
Hovering of row labels applies new style
darrenburns Feb 23, 2023
9aa3d6f
Remove a print
darrenburns Feb 23, 2023
48b3252
Ensure horizontal scrolling with column cursor accounts for row label…
darrenburns Feb 23, 2023
06149b1
Account for possible row labels in cell cursor horizontal scrolling
darrenburns Feb 23, 2023
93e6983
Ensure cursor highlighting is correct on row label cells
darrenburns Feb 23, 2023
1cc7e40
Merge branch 'main' of github.com:Textualize/textual into datatable-l…
darrenburns Feb 23, 2023
49b5d26
Document component class for DataTable label hover
darrenburns Feb 23, 2023
eb8672c
Test to ensure clicking row label emits correct event
darrenburns Feb 23, 2023
18cb467
Add snapshot test for DataTable with fixed rows/cols and row labels
darrenburns Feb 23, 2023
af6c236
Using pilot pause instead of wait_for_idle directly
darrenburns Feb 23, 2023
0361bf4
Update CHANGELOG
darrenburns Feb 23, 2023
64da2c8
Add a docstring
darrenburns Feb 23, 2023
9f8d13e
Add a note to CHANGELOG.md about RowLabelSelected
darrenburns Feb 23, 2023
4413e8e
Merge branch 'main' into datatable-labelling-rows
darrenburns Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,17 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Added horizontal rule to Markdown https://github.com/Textualize/textual/pull/1832
- Added `Widget.disabled` https://github.com/Textualize/textual/pull/1785
- Added `DOMNode.notify_style_update` to replace `messages.StylesUpdated` message https://github.com/Textualize/textual/pull/1861
- Added `DataTable.show_row_labels` reactive to show and hide row labels https://github.com/Textualize/textual/pull/1868
- Added `DataTable.RowLabelSelected` event, which is emitted when a row label is clicked https://github.com/Textualize/textual/pull/1868
- Added `MessagePump.prevent` context manager to temporarily suppress a given message type https://github.com/Textualize/textual/pull/1866

### Changed

- Scrolling by page now adds to current position.
- Markdown lists have been polished: a selection of bullets, better alignment of numbers, style tweaks https://github.com/Textualize/textual/pull/1832
- Added alternative method of composing Widgets https://github.com/Textualize/textual/pull/1847
- Added `label` parameter to `DataTable.add_row` https://github.com/Textualize/textual/pull/1868
- Breaking change: Some `DataTable` component classes were renamed - see PR for details https://github.com/Textualize/textual/pull/1868

### Removed

Expand Down
Loading