Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend @on decorator to filter matchable attributes #2498

Merged
merged 27 commits into from
May 8, 2023
Merged

Extend @on decorator to filter matchable attributes #2498

merged 27 commits into from
May 8, 2023

Commits on May 5, 2023

  1. Add tests for #2484.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 5, 2023
    Configuration menu
    Copy the full SHA
    4a57e14 View commit details
    Browse the repository at this point in the history

  2. Implement @on extension. 

    [skip ci]
Related issues: #2484.
    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 5, 2023
    Configuration menu
    Copy the full SHA
    83b0ae7 View commit details
    Browse the repository at this point in the history

  3. Changelog.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 5, 2023
    Configuration menu
    Copy the full SHA
    2898b1d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Add missing @on test.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e77b366 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into on-kwargs

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e097d64 View commit details
    Browse the repository at this point in the history

  3. Remove debug prints.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8febe0f View commit details
    Browse the repository at this point in the history

  4. Document changes.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    0950e51 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into on-kwargs

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    6434149 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into on-kwargs

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    938fa3b View commit details
    Browse the repository at this point in the history

  7. Update tests. 

    Test now fully works, as of #2490.
    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    51139c4 View commit details
    Browse the repository at this point in the history

  8. Cache parsed selectors.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    bd34558 View commit details
    Browse the repository at this point in the history

  9. Streamline exit condition.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    4f6ca0e View commit details
    Browse the repository at this point in the history

  10. Fix typing.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    3adf63c View commit details
    Browse the repository at this point in the history

  11. More succint wording.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f1d6652 View commit details
    Browse the repository at this point in the history

  12. Document 'on' kwargs.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    0abb99f View commit details
    Browse the repository at this point in the history

  13. Update src/textual/_on.py 

    Co-authored-by: Will McGugan <[email protected]>
    @rodrigogiraoserrao @willmcgugan
    rodrigogiraoserrao and willmcgugan authored May 8, 2023
    Configuration menu
    Copy the full SHA
    64f1253 View commit details
    Browse the repository at this point in the history

  14. Update docs/guide/events.md 

    Co-authored-by: Will McGugan <[email protected]>
    @rodrigogiraoserrao @willmcgugan
    rodrigogiraoserrao and willmcgugan authored May 8, 2023
    Configuration menu
    Copy the full SHA
    6b08b3c View commit details
    Browse the repository at this point in the history

  15. Change 'on' API.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    a7cc55e View commit details
    Browse the repository at this point in the history

  16. Remove example code.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    813a91a View commit details
    Browse the repository at this point in the history

  17. Address feedback.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    36ee21f View commit details
    Browse the repository at this point in the history

  18. Update src/textual/_on.py 

    Co-authored-by: Will McGugan <[email protected]>
    @rodrigogiraoserrao @willmcgugan
    rodrigogiraoserrao and willmcgugan authored May 8, 2023
    Configuration menu
    Copy the full SHA
    63f2853 View commit details
    Browse the repository at this point in the history

  19. Address review feedback.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    3842911 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' into on-kwargs

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    054b1c1 View commit details
    Browse the repository at this point in the history

  21. Fix #2499.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed May 8, 2023
    Configuration menu
    Copy the full SHA
    5120f9e View commit details
    Browse the repository at this point in the history

  22. don't require control to be manually specified

    @willmcgugan
    willmcgugan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    aa911e9 View commit details
    Browse the repository at this point in the history

  23. update docstring

    @willmcgugan
    willmcgugan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    64f7fba View commit details
    Browse the repository at this point in the history

  24. deleted words

    @willmcgugan
    willmcgugan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    84ca784 View commit details
    Browse the repository at this point in the history