-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend @on
decorator to filter matchable attributes
#2498
Conversation
[skip ci] Related issues: #2484.
Tests will pass as soon as I merge #2490. |
Test now fully works, as of #2490.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willmcgugan still trying to strike a balance between my personal verbose style and the intended style for the docs.
Let me know how this looks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dead code in the example is a blocker. Either we come up with a working example, or we don't bother with an example for this.
Co-authored-by: Will McGugan <[email protected]>
Co-authored-by: Will McGugan <[email protected]>
@on
decorator to filter arbitrary attributes@on
decorator to filter matchable attributes
Changed the API so that now the |
Co-authored-by: Will McGugan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The decorator
@on
now accepts keyword arguments to provide selectors for attributes that the message has whitelisted inON_MATCHABLE_ATTRIBUTES
.This will close #2484.