Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect some report commands #6144

Closed
wants to merge 9 commits into from

Conversation

gadfort
Copy link
Collaborator

@gadfort gadfort commented Nov 12, 2024

Replaces: #6046

Changes:
add redirect to some report_* commands.

oharboe and others added 5 commits October 29, 2024 13:45
same as all other commands, don't know why this one slipped
between the cracks

Signed-off-by: Øyvind Harboe <[email protected]>
@gadfort
Copy link
Collaborator Author

gadfort commented Nov 12, 2024

@oharboe FYI

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gadfort
Copy link
Collaborator Author

gadfort commented Nov 14, 2024

With #6160 this PR is not needed. Unless @oharboe feels strongly about it, I would be fine closing it.

@maliberty
Copy link
Member

I'm fine as well.

@oharboe
Copy link
Collaborator

oharboe commented Nov 15, 2024

a general tee command seems more tcl idiomatic to me, less surprising...

@maliberty maliberty closed this Nov 15, 2024
@gadfort gadfort deleted the redirect-some branch November 15, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants