Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utl: add tee TCL command #6160

Merged
merged 8 commits into from
Nov 14, 2024
Merged

utl: add tee TCL command #6160

merged 8 commits into from
Nov 14, 2024

Conversation

gadfort
Copy link
Collaborator

@gadfort gadfort commented Nov 14, 2024

Signed-off-by: Peter Gadfort <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Peter Gadfort <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Peter Gadfort <[email protected]>
Signed-off-by: Peter Gadfort <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

This seems to make the previous PR for redirection redundant as tee -quiet does the same.

@maliberty
Copy link
Member

I know its a bit odd but what happens with tee -file foo { report_checks > bar }?

src/utl/README.md Outdated Show resolved Hide resolved
src/utl/src/Logger.cpp Outdated Show resolved Hide resolved
Signed-off-by: Peter Gadfort <[email protected]>
@gadfort
Copy link
Collaborator Author

gadfort commented Nov 14, 2024

This seems to make the previous PR for redirection redundant as tee -quiet does the same.

@maliberty yes, this provides a consistent interface to use.

I know its a bit odd but what happens with tee -file foo { report_checks > bar }?

I don't think we want to support that, so it should throw an error.

@maliberty
Copy link
Member

should throw an error.

Does it?

@gadfort
Copy link
Collaborator Author

gadfort commented Nov 14, 2024

should throw an error.

Does it?

It does now.

I also added the variable redirect to round out the options (since I use it in a few places via with_output_to_variable).

Signed-off-by: Peter Gadfort <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty merged commit d34d2ba into The-OpenROAD-Project:master Nov 14, 2024
11 checks passed
@gadfort gadfort deleted the tee branch November 14, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants