Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Record Basics section of Rails course: Add Basic Validations lesson #27651

Merged

Conversation

Leo-U
Copy link
Contributor

@Leo-U Leo-U commented Mar 20, 2024

Because

Submitting new lesson for work on this issue.

This PR

In basic_validations.md:

  • Divides validations content between headers.
  • Adds additional content.
  • Edits existing content.

In active_record_basics.md:

  • Removes validations content and removes a passage from the Assignment.

In basic_associations.md:

  • Corrects Lesson overview and inserts said passage.

Issue

Related to #27477

Additional Information

I tried to make the commits more coherent this time. I imagine that probably the easiest way to understand my proposed changes would be to go through that commit history.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Mar 20, 2024
@Leo-U Leo-U force-pushed the Add_basic_validations_rails_lesson branch 9 times, most recently from 16b69ef to 7d9f172 Compare March 23, 2024 13:02
@Leo-U Leo-U force-pushed the Add_basic_validations_rails_lesson branch from 7d9f172 to 744a2fc Compare March 23, 2024 14:01
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for contributing!

I'll work on getting this live on the site soon.

@JoshDevHub JoshDevHub self-assigned this Mar 25, 2024
@JoshDevHub JoshDevHub merged commit da8b302 into TheOdinProject:main Mar 25, 2024
2 of 3 checks passed
@Leo-U Leo-U deleted the Add_basic_validations_rails_lesson branch March 26, 2024 11:51
JoshDevHub added a commit to TheOdinProject/theodinproject that referenced this pull request Mar 27, 2024
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
There's a new lesson for the Rails course on validations added in this
PR to the curriculum repo:
TheOdinProject/curriculum#27651

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
- Adds new lesson to the Rails course fixtures
- Runs `db:seed` task

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Closes #XXXXX

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->


## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [ ] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants