Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feature Flag #4524

Closed
4 tasks
bycdiaz opened this issue May 11, 2024 · 1 comment
Closed
4 tasks

Add Feature Flag #4524

bycdiaz opened this issue May 11, 2024 · 1 comment

Comments

@bycdiaz
Copy link
Member

bycdiaz commented May 11, 2024 •
edited
Loading

  • Add feature flag
  • Add placeholder content (content we're hiding)
  • Add test confirming users with flag can observe hidden content
  • Add test confirming users without flag cannot observe hidden content.

Acceptance Criteria

  1. Enable flag for your current user
  2. Navigate to x
  3. Observe hidden content
@github-project-automation github-project-automation bot moved this to 📋 Backlog / Ideas in Main Site May 11, 2024
@JustWaveThings
Copy link
Contributor

From meeting on 5/11:

@JustWaveThings JustWaveThings mentioned this issue May 30, 2024
Merged
KevinMulhern pushed a commit that referenced this issue Jun 4, 2024
@JustWaveThings
Feature/mvp interview survey (#4549)
6950307 
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
- We need a feature flag to hide the interview survey feature behind. 

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
- Creates route, controller, view, and updates flipper gates
- Adds feature flag check to controller
- System test coverage for feature flag behavior to ensure no one can
access the feature if it is disabled

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Related to #4524  

~~Missing tests that were called for in that issue.~~ There are now two
system tests.

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->

~~The feature flag does work correctly in the view, but I'm not getting
a redirect to work in the controller if the feature is disabled. It
still renders the page as if the feature was enabled.~~ This is
resolved.
@github-project-automation github-project-automation bot moved this from 📋 Backlog / Ideas to ✅ Done in Main Site Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Main Site
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KevinMulhern @bycdiaz @JustWaveThings