Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: SQL Zoo: No need for community solutions #4630

Closed
3 tasks done
dilpreetsinghaulakh opened this issue Jul 20, 2024 · 5 comments · Fixed by #4677
Closed
3 tasks done

Project: SQL Zoo: No need for community solutions #4630

dilpreetsinghaulakh opened this issue Jul 20, 2024 · 5 comments · Fixed by #4677
Assignees
@dilpreetsinghaulakh

Comments

@dilpreetsinghaulakh
Copy link
Contributor

dilpreetsinghaulakh commented Jul 20, 2024 •
edited
Loading

Checks

Describe your suggestion

SQL Zoo is solved in the browser so there is no need for community solutions as there is no obvious way to share the solution.

Also, "feedback form for the SQL course" leads to (says) ruby on rails form even in NodeJS path.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-databases-sql-zoo

(Optional) Discord Name

No response

(Optional) Additional Comments

Just small discrepancies!
@wise-king-sullyman
Copy link
Member

Thanks for submitting this issue!

I fixed the google form issue since that requires admin access to our gforms.

For the SQL Zoo lesson submissions I believe that change requires an update in our site repo, specifically of the accepts_submissions key for the lesson in its fixture file, so I'm going to transfer this issue to that repo.

Are you still interested in making that change?

@wise-king-sullyman wise-king-sullyman transferred this issue from TheOdinProject/curriculum Jul 21, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog / Ideas in Main Site Jul 21, 2024
@dilpreetsinghaulakh
Copy link
Contributor Author

I think it can actually stay as I have just seen a submission in which the submitter put the solutions for SQL Zoo in a repository. Although I still don't think it is the best implementation here.

@MaoShizhong
Copy link
Contributor

I feel like user submissions isn't really that relevant here given the SQLZoo exercises are marked right or wrong when you do them. So I'm in favour of just removing the submissions component for that lesson.

@Asartea
Copy link
Contributor

Asartea commented Jul 22, 2024

Agree with Mao that there is no real point to storing these, since there is already build in checking

@MaoShizhong
Copy link
Contributor

@dilpreetsinghaulakh Are you still happy to be assigned to this issue and change the accepts_submissions value to false as per wise-king-sullyman's comment above?

@dilpreetsinghaulakh dilpreetsinghaulakh mentioned this issue Jul 30, 2024
Merged
7 tasks
KevinMulhern pushed a commit that referenced this issue Aug 1, 2024
@dilpreetsinghaulakh
Feature: Update accepts_submission to false in database_lessons.rb (#…
ebc5328 
…4677)

<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
Submissions in SQL Zoo project does not make sense as solutions are self
validated.

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->

- Change accepts_submission to false

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Closes #4630

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->


## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
@github-project-automation github-project-automation bot moved this from 📋 Backlog / Ideas to ✅ Done in Main Site Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilpreetsinghaulakh dilpreetsinghaulakh

Labels
None yet
Projects
Main Site
Archived in project
Milestone
No milestone
4 participants
@wise-king-sullyman @Asartea @dilpreetsinghaulakh @MaoShizhong