Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo in title 'The React Ecocsystem' #4037

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

RushilJalal
Copy link
Contributor

@RushilJalal RushilJalal commented Jul 27, 2023

Because

It fixes the typo in the title 'The React Ecocsystem' in file react.rb in both full_stack_rails and full_stack_javascript folders. The file locations are:


This PR

  • 'The React Ecocsystem' was changed to 'The React Ecosystem' in 6 instances, 3 in each file.

Issue

Closes #4034

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behavior
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RushilJalal

@KevinMulhern KevinMulhern merged commit ac5028c into TheOdinProject:main Jul 27, 2023
@RushilJalal RushilJalal deleted the fix_title_typo branch July 28, 2023 04:57
Mclilzee pushed a commit to Mclilzee/theodinproject that referenced this pull request Aug 2, 2023
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
It fixes the typo in the title 'The React Ecocsystem' in file `react.rb`
in both full_stack_rails and full_stack_javascript folders. The file
locations are:
https://github.com/TheOdinProject/theodinproject/blob/5ae47989ad1d42ba0c045bac7534c8b3592b9e63/db/fixtures/paths/full_stack_rails/courses/react.rb#L90

https://github.com/TheOdinProject/theodinproject/blob/5ae47989ad1d42ba0c045bac7534c8b3592b9e63/db/fixtures/paths/full_stack_javascript/courses/react.rb#L90

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->

- 'The React Ecocsystem' was changed to 'The React Ecosystem' in 6
instances, 3 in each file.

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes TheOdinProject#2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
TheOdinProject#2013'.
-->
Closes TheOdinProject#4034 

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->



## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
  - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
  - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [x] If applicable, this PR includes new or updated automated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

React(NEW): Typo in Lesson block heading 'The React Ecocsystem'
2 participants