[Project. Status] Version 6.0.0-alpha #2723

hueniverse · 2022-06-15T19:36:30Z

After a long period of inactivity, developments have restarted in this repository. V6.x branch already contains number of alpha releases.

These releases includes many bug fixes and improvements from many contributors. I want to express my deep gratitude for all the help in getting this important milestone. Many contributors had to rebase their contributions multiple times as some where a few years old.

Please test the new release with your app and report back any issues. Please clearly label your issues as v6 so that we can prioritize them.

Main changes in V6 branch:

Remove support for DOM
Remove support for Android media player (only support Exo player)
Rewrite AVPlayer (ios) binding in swift
Add client side ads insertion on ios and android (google ima)
Update exoplayer to media3

This branch should now be be stable, we reach the beta state.
Please report any regressions comparing to 5.2.1, they will be handled as a priorityand tagged https://github.com/react-native-video/react-native-video/labels/critical%20for%20release
If you want to contribute, following ticket are a good first approach: https://github.com/react-native-video/react-native-video/labels/good%20first%20issue

Roadmap to be discussed here: #3351
Project status discussions here: #3350

(Edited by @freeboub)

JstnEdr · 2022-06-16T16:47:56Z

Looks like fullscreen video on Android is still not supported. Are there any plans to address this in v6?

hueniverse · 2022-06-17T08:02:15Z

@JstnEdr if there is a PR ready or someone willing to take the lead, sure. There are no free resources around atm...

baveku · 2022-06-21T09:51:54Z

I hope we can custom control UI, on iOS it's beautiful but on Android, we don't have a fullscreen button.
With 0.69.0 we need to integrate using New Architecture, I think we need to migrate this library.

JongGyuChoi · 2022-06-22T01:58:34Z

A build error occurred in RCTVideoManager

.

baveku · 2022-06-22T02:16:11Z

A build error occurred in RCTVideoManager

.

I guess you use version v6 on npm,
so you need to move from npm to github repo
"react-native-video": "react-native-video/react-native-video"
to fix it

Dr-Horv · 2022-06-27T09:36:48Z

@hueniverse Any ETA how long the alpha vill be ongoing and when the 6.0 release will happen?

Not asking to stress, but need to know for a project I'm working on if we need to go through the hoops (documentation, signoff etc) of using an alpha-version of a library in our next production release since we have conflicts with another dependency on the Exoplayer and can't keep using 5.2

hueniverse · 2022-06-27T11:47:44Z

@Dr-Horv Hard to say but hopefully an official v6 by end of July. The main blocker is that we only have 2-3 people actually doing the work. If more people reviewed PRs and approved them (or report issues), we would be moving much faster.

rafaelbrun · 2022-08-15T13:18:53Z

@hueniverse @freeboub or anyone that can provide some information. Is there any updates on an ETA for the 6.0 release? And what is needed so that this release can happen?

I'm working in a project that our main resource is using this lib, me and my team may be able to help if we have some information about how much work is left to get this release out.

You can reach me out on my email if you think that's better: [email protected]

Thanks for you hard work on this amazing lib!!

hueniverse · 2022-08-16T08:15:30Z

@rafaelbrun see: #2788

rafaelbrun · 2022-08-16T11:00:37Z

@hueniverse @freeboub or anyone that can provide some information. Is there any updates on an ETA for the 6.0 release? And what is needed so that this release can happen?

I'm working in a project that our main resource is using this lib, me and my team may be able to help if we have some information about how much work is left to get this release out.

You can reach me out on my email if you think that's better: [email protected]

Thanks for you hard work on this amazing lib!!

@cobarx

freeboub · 2022-08-20T13:36:45Z

@rafaelbrun
Hello, I invite you on a slack channel.
I advice you to fork this repo for your corporate usage...
I will take the lead for releases, but I am doing it only on my spare time, so I cannot be 'reactive' every days :)
Thank you.

smikheiev · 2022-09-13T11:28:35Z

are there some plans about releasing 6.0.0-alpha.2? there's 6.0.0-alpha.2 and even 6.0.0-alpha3 in the changelog, but the latest released version in npm is 6.0.0-alpha1? 🤔

freeboub · 2022-09-17T15:02:15Z

Version 6.0.0.alpha.3 has been released on npm

jemise111 · 2022-10-10T15:38:32Z

Hey @hueniverse @freeboub (or anyone else who can help). Thank you for all of the hard work on v6. We're trialing using the latest alpha in our app, as it is required for compatibility with another dependency we're using, react-native-track-player.

I was wondering if there is a list of known issues/risks in the latest alpha release anywhere, so we may know what to look out for in testing the stability of v6 in its current state?

Thanks for any help 🙏

Lakston · 2022-10-25T06:20:06Z

In alpha 3 you are using a fork of ScalableVideoView, is that really needed ?

It is causing Duplicate class issues on android builds if another lib is using ScalableVideoView.

freeboub · 2022-10-25T21:09:16Z

@Lakston ScalableVideoView is not used anymore in V6.0.0
@jemise111 there is no possibility to use mulitple exoplayer version in my knowledge ...

HaddyYang · 2022-10-30T02:39:44Z

The fullscreenOrientation attribute is not work in [email protected], both Android and iOS.
My react-native version is 0.70.3

DennisdeWitNL · 2022-11-01T15:06:27Z

alpha.3 completely breaks iOS

node_modules/react-native-video/ios/Video/RCTVideo.swift:24:34: error build: Cannot find type 'RCTEventDispatcher' in scope

zchwyng · 2022-11-21T14:50:17Z

When will alpha 4 be released to npm?

marcel-happyfloat · 2022-12-03T10:26:29Z

alpha 3 works great for me in development, but in release build it keeps crashing almost instantly (most of the time, but sometimes it takes a while of scrolling up and down in my item feed) with this error:

EXC_BREAKPOINT react_native_video.RCTVideoPlayerViewController
reactViewController > superview > ticalCornerRadius:

Similar issues grouped together in sentry error reporting, e.g:

RNSScreen | EXC_BREAKPOINT: dyld_v1 arm64e > iOntology27UsoEntity_common_Arithmetic > reactViewController > > superview

EXC_BREAKPOINT react_native_video.RCTVideoPlayerViewController
ePower > reactViewController > superview

Anybody has an idea whats wrong?

alpha 4 is not yet released to test.

Edit: I tried to set a fixed video height to the parent container too, but I don't think it did change anything.
Edit: I also added this patch to my alpha 3 version from alpha 4: #2907 and I think this issue is new, but not sure.

NSInternalInconsistencyException react_native_video.RCTVideoPlayerViewController
NSInternalInconsistencyException: Cannot remove an observer <NSKeyValueObservance 0x28266b390> for the key path "currentItem.playbackBufferEmpty" from <AVPlayer 0x282ae9970>, most likely because the value for the key "currentItem" has changed without an appropriate KVO notification being sent. Check the KVO-compliance of the AVPlayer class.

marcel-happyfloat · 2022-12-06T11:06:22Z

This time I catched some error in XCode and I could solve my problem by doing this:

diff --git a/node_modules/react-native-video/ios/Video/RCTVideo.swift b/node_modules/react-native-video/ios/Video/RCTVideo.swift
index 47231a7..3dc48e1 100644
--- a/node_modules/react-native-video/ios/Video/RCTVideo.swift
+++ b/node_modules/react-native-video/ios/Video/RCTVideo.swift
@@ -646,7 +646,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
         
         if _controls {
             let viewController:UIViewController! = self.reactViewController()
-            viewController.addChild(_playerViewController)
+            viewController?.addChild(_playerViewController)
             self.addSubview(_playerViewController.view)
         }

freeboub · 2022-12-06T12:04:22Z

@happyfloat can you please open a PR with this change ?

Prevents a crash in my case: TheWidlarzGroup#2723 (comment)

tsalama · 2023-02-21T16:11:23Z

Hey guys, just curious if there's a list of outstanding TODOs and necessary tasks before v6 officially goes live? I see alpha.5 was released last week though, awesome work.

Larens94 · 2023-02-27T21:52:03Z

@Lakston ScalableVideoView is not used anymore in V6.0.0 @jemise111 there is no possibility to use mulitple exoplayer version in my knowledge ...

how did you solve the problem?
I currently receive:
Caused by: java.lang.RuntimeException: Duplicate class com.yqritc.scalablevideoview.BuildConfig found in modules jetified-Android-ScalableVideoView-10e7b4da8b-runtime (com.github.adityaxjha:Android-ScalableVideoView:10e7b4da8b) and jetified-android-scalablevideoview- v1.0.4-jitpack-runtime (com.github.MatrixFrog:android-scalablevideoview:v1.0.4-jitpack)

eugened-ith · 2023-04-13T01:55:50Z

Hi! Coming from expo-av because of android crash. Tried both react-native-video v5.2.1 and
v6.0.0-alpha.6 the app crashes with alpha with same error as expo-av with the next stack trace

java.lang.OutOfMemoryError: Failed to allocate a 2944 byte allocation with 47976 free bytes and 46KB until OOM, target footprint 268435456, growth limit 268435456; giving up on allocation because <1% of heap free after GC.
    at java.lang.AbstractStringBuilder.<init>(AbstractStringBuilder.java:69)
    at java.lang.StringBuilder.<init>(StringBuilder.java:102)
    at java.lang.String.replace(String.java:2787)
    at com.google.android.exoplayer2.util.Log.appendThrowableString(Log.java:295)
    at com.google.android.exoplayer2.util.Log.e(Log.java:254)
    at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:440)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
    at java.lang.Thread.run(Thread.java:1012)

The context is that I'm working on a twitter-like app and have a flash list of videos and other media that comes from IPFS and they can have rather big size, probably up to 1.5GB but I don't have any ability to compress these files anyhow so they come to app as is.

I'll go with v5.2.1 now as it just works now, but I'm wondering what can cause such problem in both react-native-video and expo-av.

I also have enabled android:largeHeap and android:hardwareAccelerated.

Thank you!

lutfullo777 · 2023-07-31T12:44:02Z

Is getting videoTrack added for IOS when onLoad video?

tsalama · 2023-08-30T17:01:26Z

Hi all, just curious if there's a list of outstanding TODOs and necessary tasks blocking the official v6 release? I see alpha.7 was released last month though, awesome work to those who contributed.

freeboub · 2023-08-31T06:37:04Z

@tsalama the list of ticketed I tagged as mandatory:
https://github.com/react-native-video/react-native-video/issues?q=is%3Aopen+is%3Aissue+label%3A%22critical+for+release%22

I hope it will be enough to have at least the same stability than 5.2

tsalama · 2023-08-31T06:52:40Z

@freeboub Ok great to know thank you.

bulkinav · 2023-10-05T15:13:10Z

Currently the 'pictureinpicture' pros only support IOS. Is there an understanding when it will be available for Android?

I see the old PR for react-native-video 5.x (#1776), but would like to see and for 6.x

In my opinion, this is a very popular feature.

boiboif · 2023-11-01T09:26:48Z

Hello, when will alpha 9 be released to npm? I need typescript support. Thanks.

vargajacint · 2023-11-01T09:35:13Z

@boiboif You can add "@types/react-native-video" to your devDependencies until it's not released, or you can specify a remote branch name instead of the version number

boiboif · 2023-11-02T03:15:44Z

@boiboif You can add "@types/react-native-video" to your devDependencies until it's not released, or you can specify a remote branch name instead of the version number

@vargajacint Thanks!

freeboub · 2023-11-04T16:18:58Z

Dear all,
alpha.9 has finally be released ! 🚀
Notice that the typescript support has finally be integrated.
Here is change log: https://github.com/react-native-video/react-native-video/releases
Thank you to all contributors, and special thank to @KrzysztofMoch !

EvelynGuoEntain · 2023-11-14T04:34:03Z

Hi team, when will the migration to androix.media3 be included in new release? Thanks.

avencat · 2023-11-22T15:06:23Z

Hi @EvelynGuoEntain it seems it is built in 6.0.0-beta.0

afkcodes · 2023-12-10T03:13:16Z

Hello is MergingMediaSource is going to be available in 6.0 or is it planned to be supported ?

freeboub · 2024-03-10T21:36:05Z

let's continue this discussion in #3350

hueniverse added the discussion label Jun 15, 2022

hueniverse pinned this issue Jun 15, 2022

hueniverse changed the title ~~Version 6.0.0-alpha.0~~ Version 6.0.0-alpha Jun 22, 2022

dlavrantonis mentioned this issue Jul 21, 2022

Android: Playback of m38u url fails #2779

Closed

marcel-happyfloat added a commit to marcel-happyfloat/react-native-video that referenced this issue Dec 7, 2022

Update RCTVideo.swift

fffe973

Prevents a crash in my case: TheWidlarzGroup#2723 (comment)

marcel-happyfloat mentioned this issue Dec 7, 2022

Update RCTVideo.swift #2943

Merged

douzal34 mentioned this issue Feb 22, 2023

Several Video instance in memory not working on Android #2984

Closed

freeboub changed the title ~~Version 6.0.0-alpha~~ [Project. Status] Version 6.0.0-alpha Oct 5, 2023

freeboub closed this as completed Mar 10, 2024

KrzysztofMoch unpinned this issue May 20, 2024

[Project. Status] Version 6.0.0-alpha #2723

[Project. Status] Version 6.0.0-alpha #2723

Comments

hueniverse commented Jun 15, 2022 • edited by freeboub Loading

JstnEdr commented Jun 16, 2022

hueniverse commented Jun 17, 2022

baveku commented Jun 21, 2022 • edited Loading

JongGyuChoi commented Jun 22, 2022

baveku commented Jun 22, 2022 • edited Loading

Dr-Horv commented Jun 27, 2022

hueniverse commented Jun 27, 2022

rafaelbrun commented Aug 15, 2022

hueniverse commented Aug 16, 2022

rafaelbrun commented Aug 16, 2022

freeboub commented Aug 20, 2022

smikheiev commented Sep 13, 2022

freeboub commented Sep 17, 2022

jemise111 commented Oct 10, 2022

Lakston commented Oct 25, 2022 • edited Loading

freeboub commented Oct 25, 2022

HaddyYang commented Oct 30, 2022

DennisdeWitNL commented Nov 1, 2022 • edited Loading

zchwyng commented Nov 21, 2022

marcel-happyfloat commented Dec 3, 2022 • edited Loading

marcel-happyfloat commented Dec 6, 2022

freeboub commented Dec 6, 2022

tsalama commented Feb 21, 2023 • edited Loading

Larens94 commented Feb 27, 2023

eugened-ith commented Apr 13, 2023

lutfullo777 commented Jul 31, 2023

tsalama commented Aug 30, 2023

freeboub commented Aug 31, 2023

tsalama commented Aug 31, 2023

bulkinav commented Oct 5, 2023 • edited Loading

boiboif commented Nov 1, 2023

vargajacint commented Nov 1, 2023

boiboif commented Nov 2, 2023 • edited Loading

freeboub commented Nov 4, 2023 • edited Loading

EvelynGuoEntain commented Nov 14, 2023

avencat commented Nov 22, 2023

afkcodes commented Dec 10, 2023

freeboub commented Mar 10, 2024

hueniverse commented Jun 15, 2022 •

edited by freeboub

Loading

baveku commented Jun 21, 2022 •

edited

Loading

baveku commented Jun 22, 2022 •

edited

Loading

Lakston commented Oct 25, 2022 •

edited

Loading

DennisdeWitNL commented Nov 1, 2022 •

edited

Loading

marcel-happyfloat commented Dec 3, 2022 •

edited

Loading

tsalama commented Feb 21, 2023 •

edited

Loading

bulkinav commented Oct 5, 2023 •

edited

Loading

boiboif commented Nov 2, 2023 •

edited

Loading

freeboub commented Nov 4, 2023 •

edited

Loading