fix: fix the memory leak #2907
Merged
fix: fix the memory leak #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks OK for me, can you add a small comment in changeLog please ? |
wood1986
force-pushed
the
bugfix/ios-memory-leak
branch
from
b516a87
to
86a89ea
Compare
|
done |
|
looks OK for me, should I merge this PR ? |
|
I think this can be merged. But do not publish a new version until we resolve #2908 |
|
The memory leak still exists. A quick way to reproduce is using this sample made by @wood1986 Add a breakpoint in deinit ( RCTVideo l.161 ), it's never called
|
|
@cguino Was this leak fixed in a future release? I am currently running into weak reference overflow errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2906 and #2809