Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename add_rstudioconnect_file to add_positconnect_file #888

Closed
ColinFay opened this issue Jul 27, 2022 · 1 comment
Closed

Rename add_rstudioconnect_file to add_positconnect_file #888

ColinFay opened this issue Jul 27, 2022 · 1 comment
Milestone
Version 0.5.0

Comments

@ColinFay
Copy link
Member

"We will rename them to Posit Connect, Posit Workbench, and Posit Package Manager so it’s easier for folks to understand that we support more than just R."

https://www.rstudio.com/blog/rstudio-is-becoming-posit/

Todo in October
@ColinFay ColinFay added this to the Version 0.5.0 milestone Dec 15, 2022
ColinFay added a commit that referenced this issue Mar 10, 2023
@ColinFay
feat: rstudio => posit
2ef07dd 
Issue #888
ilyaZar added a commit to ilyaZar/golem that referenced this issue Mar 31, 2023
@ilyaZar
refactor: rename from rstudioconnect to positconnect
67c01ff 
rename add_rstudioconnect_file() to add_positconnect_file() in files:

- add_rstudio_files.R
- vignettes/c_deploy.Rmd
- tests/testthat/test-add_deploy_helpers.R
- inst/mantest/build.R
- inst/shinyexamle/dev/03_deploy.R
- _pkgdown.yml

Not touching NAMESPACE, .Rd-files, and NEWS.md as they are updated otherwise.

Refs: ThinkR-open#888
@ilyaZar ilyaZar mentioned this issue Mar 31, 2023
Merged
ilyaZar added a commit to ilyaZar/golem that referenced this issue Mar 31, 2023
@ilyaZar
refactor: rename from rstudioconnect to positconnect
c094f81 
rename add_rstudioconnect_file() to add_positconnect_file() in files:

- add_rstudio_files.R
- vignettes/c_deploy.Rmd
- tests/testthat/test-add_deploy_helpers.R
- inst/mantest/build.R
- inst/shinyexamle/dev/03_deploy.R
- _pkgdown.yml

Not touching NAMESPACE, .Rd-files, and NEWS.md as they are updated otherwise.

Refs: ThinkR-open#888
ilyaZar added a commit to ilyaZar/golem that referenced this issue Apr 5, 2023
@ilyaZar
refactor: rename from rstudioconnect to positconnect
deaf496 
rename add_rstudioconnect_file() to add_positconnect_file() in files:

- add_rstudio_files.R
- vignettes/c_deploy.Rmd
- tests/testthat/test-add_deploy_helpers.R
- inst/mantest/build.R
- inst/shinyexamle/dev/03_deploy.R
- _pkgdown.yml

Not touching NAMESPACE, .Rd-files, and NEWS.md as they are updated otherwise.

Keep  add_rstudioconnect_file for compatibility but with depcrecation
note.

Refs: ThinkR-open#888
VincentGuyader pushed a commit that referenced this issue Aug 2, 2023
@ilyaZar
refactor: rename from rstudioconnect to positconnect (#1017)
ac5211a 
rename add_rstudioconnect_file() to add_positconnect_file() in files:

- add_rstudio_files.R
- vignettes/c_deploy.Rmd
- tests/testthat/test-add_deploy_helpers.R
- inst/mantest/build.R
- inst/shinyexamle/dev/03_deploy.R
- _pkgdown.yml

Not touching NAMESPACE, .Rd-files, and NEWS.md as they are updated otherwise.

Keep  add_rstudioconnect_file for compatibility but with depcrecation
note.

Refs: #888
@ColinFay
Copy link
Member Author

ColinFay commented Aug 7, 2024

Done

@ColinFay ColinFay closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.5.0
Development

No branches or pull requests
1 participant
@ColinFay