Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename from rstudioconnect to positconnect #1017

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ilyaZar
Copy link
Contributor

@ilyaZar ilyaZar commented Mar 31, 2023

Fix #888

rename add_rstudioconnect_file() to add_positconnect_file() in files:

  • add_rstudio_files.R
  • vignettes/c_deploy.Rmd
  • tests/testthat/test-add_deploy_helpers.R
  • inst/mantest/build.R
  • inst/shinyexamle/dev/03_deploy.R
  • _pkgdown.yml

Not touching NAMESPACE, .Rd-files, and NEWS.md as they are updated otherwise.

@ColinFay
Copy link
Member

ColinFay commented Apr 4, 2023

Hey,

Thanks.

I think we should first Deprecate the functions before removing them, so that the change is not too brutal for people with old dev scripts :)

So basically keeping something like :

add_rstudioconnect_file <- function(...){
  .Deprecated("add_postitconnect_file")
  add_postitconnect_file(...)
}

For the old functions ?

@ilyaZar
Copy link
Contributor Author

ilyaZar commented Apr 4, 2023

yep! updated this

edit: removed unnecessary merge commit, and joined 3commit into a single

rename add_rstudioconnect_file() to add_positconnect_file() in files:

- add_rstudio_files.R
- vignettes/c_deploy.Rmd
- tests/testthat/test-add_deploy_helpers.R
- inst/mantest/build.R
- inst/shinyexamle/dev/03_deploy.R
- _pkgdown.yml

Not touching NAMESPACE, .Rd-files, and NEWS.md as they are updated otherwise.

Keep  add_rstudioconnect_file for compatibility but with depcrecation
note.

Refs: ThinkR-open#888
@ilyaZar ilyaZar force-pushed the 888-rename_to_positconnect branch from bb9ab1e to deaf496 Compare April 5, 2023 10:11
@VincentGuyader VincentGuyader merged commit ac5211a into ThinkR-open:dev Aug 2, 2023
@VincentGuyader
Copy link
Member

thks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants