Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate for 0.4.0 #961

Merged
merged 64 commits into from
Mar 10, 2023
Merged

Release candidate for 0.4.0 #961

merged 64 commits into from
Mar 10, 2023

Conversation

ColinFay
Copy link
Member

@ColinFay ColinFay commented Dec 14, 2022

Todo before releasing this version

ColinFay and others added 30 commits October 12, 2022 21:23
We needed to release a version for golem to stay on CRAN
but a real release was not ready,
hence a small 0.3.4
We needed to release a version for golem to stay on CRAN
but a real release was not ready,
hence a small 0.3.4
Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev

# Conflicts:
#	DESCRIPTION
#	NEWS.md
#	R/add_dockerfiles.R
#	R/modules_fn.R
#	man/dockerfiles.Rd
#	tests/testthat/test-zzzzzzzzzz.R
* fix #944

force lowercase for package name in Dockerfile

* check_is_installed is back again instead of fs_file_copy for dockerfile creation 

* set version to 0.3.5.9001
* fix allow pkgload no to be installed

* fix document_and_reload rd

* chore update NEWS and bump version

* fix force repos in test to avoid  "trying to use CRAN without setting a mirror"
* remove cli and crayon from hard deps
ColinFay and others added 8 commits December 23, 2022 10:23
fix : allow using `add_dockerfile_with_renv without` attachment and/or detect if package is missing
tags: fix, doc

Why?  

- I need to be able to commit right after running the complete "dev/01_dev.R"

How?

- To commit, I need the Readme.md file to be created, after I created the Readme.Rmd file.
- devtools::build_readme() allows to install the package temporarily with its last version to be able to knit the Readme.Rmd in the last good conditions
fix: allow to build readme in 01_start
* Pass `require_suggets` to `attachment_create_renv_for_prod`

* feat : force check_if_suggests_is_installed = FALSE in renv creation

* feat : add test to check suggested package are not in renv.lock

* fix : explictly use library(appname) before launching an app un Dockerfile

issue : #978

* fix : update add_dockerfile_with_renv

* fix : check_installed is more cleaver

* fix : add {renv} to dev_deps (its already in {dockerfiler}'s deps, but it seems safer to do this.

---------

Co-authored-by: Stephen Holsenbeck <[email protected]>
@ColinFay
Copy link
Member Author

ColinFay commented Feb 3, 2023

> revdep_summary()
✔ activAnalyzer 2.0.0                    ── E: 0     | W: 0     | N: 0    
✔ apisensr 0.3.0                         ── E: 0     | W: 0     | N: 1    
✔ babsim.hospital 11.8.8                 ── E: 0     | W: 0     | N: 1    
✔ biodosetools 3.6.1                     ── E: 0     | W: 0     | N: 0    
✔ bs4Dash 2.2.1                          ── E: 0     | W: 0     | N: 1    
✔ designer 0.2.0                         ── E: 0     | W: 0     | N: 0    
I discoveR 3.1.2                         ── E: 1     | W: 0     | N: 0    
✔ dragon 1.2.1                           ── E: 0     | W: 0     | N: 1    
✔ fdapaceShiny 1.0.5                     ── E: 0     | W: 0     | N: 0    
✔ FielDHub 1.2.1                         ── E: 0     | W: 0     | N: 0    
✔ forecasteR 1.1.6                       ── E: 0     | W: 0     | N: 0    
✔ gwpcormapper 0.1.3                     ── E: 0     | W: 0     | N: 1    
✔ InterCellar 2.4.0                      ── E: 0     | W: 0     | N: 2    
✔ IsoCor 0.1.40                          ── E: 0     | W: 0     | N: 1    
✔ kesernetwork 0.1.0                     ── E: 0     | W: 0     | N: 0    
I loadeR 1.1.3                           ── E: 1     | W: 0     | N: 0    
✖ MainExistingDatasets 1.0.1             ── E: 0     | W: 0  +1 | N: 1    
✔ MicrobiomeProfiler 1.4.0               ── E: 0     | W: 0     | N: 1    
E multiSight                             ── E: ?/?   | W: ?/?   | N: ?/?  
I OlympicRshiny 1.0.0                    ── E: 1     | W: 0     | N: 0    
✔ packer 0.1.3                           ── E: 0     | W: 0     | N: 0    
✔ PERK 0.0.9.2                           ── E: 0     | W: 0     | N: 0    
✔ phecodemap 0.1.0                       ── E: 0     | W: 0     | N: 1    
✔ predictoR 2.0.7                        ── E: 0     | W: 0     | N: 0    
✔ regressoR 2.0.1                        ── E: 0     | W: 0     | N: 1    
✔ ReviewR 2.3.8                          ── E: 0     | W: 0     | N: 1    
✔ rsqliteadmin 1.0.1                     ── E: 0     | W: 0     | N: 0    
✔ ShinyLink 0.2.2                        ── E: 0     | W: 0     | N: 0    
I shinyTempSignal 0.0.3                  ── E: 1     | W: 0     | N: 0    
T spatialLIBD 1.10.1                     ── E: 1     | W: 0     | N: 2    
✔ tcgaViz 1.0.1                          ── E: 0     | W: 0     | N: 0    
✔ tidyCDISC 0.1.0                        ── E: 1     | W: 0     | N: 1    
I tripr 1.4.0                            ── E: 1     | W: 0     | N: 0    
✔ viewpoly 0.3.2                         ── E: 0     | W: 0     | N: 0    
✔ wpm 1.8.0                              ── E: 0     | W: 0     | N: 0 

@ColinFay ColinFay marked this pull request as ready for review March 10, 2023 10:41
@ColinFay ColinFay merged commit ce67fa5 into master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants