-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate for 0.4.0 #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4
We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4
Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev # Conflicts: # DESCRIPTION # NEWS.md # R/add_dockerfiles.R # R/modules_fn.R # man/dockerfiles.Rd # tests/testthat/test-zzzzzzzzzz.R
Issue Add a maintenance mode ? #820
* fix #944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001
* fix allow pkgload no to be installed * fix document_and_reload rd * chore update NEWS and bump version * fix force repos in test to avoid "trying to use CRAN without setting a mirror"
* remove cli and crayon from hard deps
fix : allow using `add_dockerfile_with_renv without` attachment and/or detect if package is missing
tags: fix, doc Why? - I need to be able to commit right after running the complete "dev/01_dev.R" How? - To commit, I need the Readme.md file to be created, after I created the Readme.Rmd file. - devtools::build_readme() allows to install the package temporarily with its last version to be able to knit the Readme.Rmd in the last good conditions
fix: allow to build readme in 01_start
* Pass `require_suggets` to `attachment_create_renv_for_prod` * feat : force check_if_suggests_is_installed = FALSE in renv creation * feat : add test to check suggested package are not in renv.lock * fix : explictly use library(appname) before launching an app un Dockerfile issue : #978 * fix : update add_dockerfile_with_renv * fix : check_installed is more cleaver * fix : add {renv} to dev_deps (its already in {dockerfiler}'s deps, but it seems safer to do this. --------- Co-authored-by: Stephen Holsenbeck <[email protected]>
|
* fix #944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo before releasing this version