MSK Modulation Fix #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a parameter, rather than using self.iq_samples_per_symbol. this is because (for now) self.iq_samples_per_symbol is used as a measure for signal bandwidth, and the actual samples per symbol may be different
ereoh
pushed a commit
that referenced
this pull request
Sep 25, 2024
* setting proper frequency deviation for GFSK, matching that of FSK * Gaussian pulse shape design for GFSK now accepts samples per symbol as a parameter, rather than using self.iq_samples_per_symbol. this is because (for now) self.iq_samples_per_symbol is used as a measure for signal bandwidth, and the actual samples per symbol may be different * ignoring temporary vim files * ignoring egg-info directory * setting modulation indices separately for MSK/GMSK, GFSK and FSK * fixing typo in variable name * fixing the frequency maps for MSK and GMSK * using a better variable name --------- Co-authored-by: TorchDSP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the MSK modulation index issue as reported in #12 , updated the frequency map for MSK and GMSK. MSK modulation is resolved, GMSK requires additional analysis and validation.