-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSK generation issues #12
Comments
@daltoncass Thank you for the issue and the detailed explanation. This seems like a relatively simple fix and we're actively working on it. |
Thank you @daltoncass , wanted to follow up with an explanation on how the fixes were made. An overarching problem was the use of iq_samples_per_symbol as a bandwidth measure, which works for QAM/PSK but does not work for FSK as you mentioned. Within the FSKDataset() class in datasets/synthetic.py, I reassign iq_samples_per_symbol variable into the variable "oversampling_rate" and then re-calculate the actual samples per symbol as based on the oversampling rate and the modulation order. This is part of the solution to problems 1 and 2 you identified. To finish problem 2, I also redefined the freq_map variable for FSK/MSK/GMSK/GFSK such that the modulation index is consistent for all higher order modulations. Prior fixes solved the randomized LPF applied to both FSK and MSK, but in reviewing the code I discovered that the GFSK/GMSK modulations were not low-pass filtered and resampled. A merge request has been submitted which corrects for this and closes out this issue. |
There are a couple of issues with the FSK signal generation:
The text was updated successfully, but these errors were encountered: