Properly Randomize LPF for GFSK/GMSK Modulations #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 13, 2023 16:24
* using the same samples per symbol (oversampling rate) for GFSK/GMSK that is defined for FSK/MSK * enabled LPF and resampling for GMSK/GFSK when random_pulse_shaping is enabled * bandwidth of LPF takes into account the signal modulation index * added function to return modulation index based on modulation name
ereoh
pushed a commit
that referenced
this pull request
Sep 25, 2024
Properly Randomize LPF for GFSK/GMSK Modulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #12 by properly defining the bandwidth of the LPF. Previous fixed resolved the issue for FSK/MSK but this fixes the problem for GFSK/GMSK. Also discovered that the GFSK/GMSK modulations were not low-pass filtered and were not resampled when random_pulse_shaping was enabled, and fixed that issue as well.