-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade external GitHub Actions actions (Node 20) #4467
Upgrade external GitHub Actions actions (Node 20) #4467
Conversation
It is important to note that this specific action must be upgraded to Node 20. @kduske I have created a PR to address this specific case: TrenchBroom/clean-commit-action#1 Once the PR is merged, I must update the current TrenchBroom GitHub Actions workflow(s) to upgrade the corresponding action to version |
Another important thing is I need you to manually create a tag to use the latest version of clean-commit-action. The tag must be named |
I see. It would be better to address this in this PR before the action gets updated. These files must already be renamed when we publish a release, because they have much more prescriptive names then. Maybe we could just move that existing renaming step to before the file gets uploaded? |
I have created the |
Something's not working properly with the new version of clean-commit-action. I'll take a look. |
…node_20_compatibility
…tibility' of github-personal:jonathanlinat/TrenchBroom into chore/upgrade_external_github_actions_for_node_20_compatibility
@kduske This PR is designed to address the malfunction in the I cannot guarantee that it will work before merging the PR. We will figure it out after merging it. Important: Please note that once it's merged, a new tag, To resolve the problem with a Linux artifact that was previously uploaded, the artifacts have been renamed according to the following convention: The workflow does not fail anymore, and the artifacts are correctly uploaded. |
Just an additional thought. Personally, I feel it would be wise to discontinue support for Windows (x32). It seems to me that not many mappers are using such an outdated architecture these days. |
Thanks, I have created the tag! |
@kduske My apologies. I completely overlooked running the Here's the PR that should definitely fix this issue: TrenchBroom/clean-commit-action#3
|
Ok, I have created the release and deleted the other ones. |
@kduske We're good now! 😃 |
For those two issues, there is a pending PR ready to be merged in the corresponding repository. However, to not block the merge of this current PR, I can create another one in the future once this action is updated: jurplel/install-qt-action#222 |
This PR aims to eliminate these warning messages in GitHub Actions as the entire infrastructure is migrating to Node 20:
The external actions must be upgraded to their newest available version.
Reference: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/