Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade external GitHub Actions actions (Node 20) #4467

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Upgrade external GitHub Actions actions (Node 20) #4467

merged 7 commits into from
Feb 5, 2024

Conversation

jonathanlinat
Copy link
Contributor

@jonathanlinat jonathanlinat commented Jan 31, 2024

This PR aims to eliminate these warning messages in GitHub Actions as the entire infrastructure is migrating to Node 20:

image

The external actions must be upgraded to their newest available version.

Reference: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@jonathanlinat jonathanlinat changed the title Upgrade external GitHub Actions (Node 20) Upgrade external GitHub Actions actions (Node 20) Jan 31, 2024
@jonathanlinat jonathanlinat changed the title Upgrade external GitHub Actions actions (Node 20) ADHOC: Upgrade external GitHub Actions actions (Node 20) Jan 31, 2024
@jonathanlinat
Copy link
Contributor Author

jonathanlinat commented Jan 31, 2024

It is important to note that this specific action must be upgraded to Node 20.

image


@kduske I have created a PR to address this specific case: TrenchBroom/clean-commit-action#1

Once the PR is merged, I must update the current TrenchBroom GitHub Actions workflow(s) to upgrade the corresponding action to version v0.8.0.

@jonathanlinat
Copy link
Contributor Author

Regarding this issue, we might need to rename the linux artifact based on the version of Ubuntu.

image

@kduske kduske changed the title ADHOC: Upgrade external GitHub Actions actions (Node 20) Upgrade external GitHub Actions actions (Node 20) Jan 31, 2024
@kduske
Copy link
Collaborator

kduske commented Jan 31, 2024

Regarding this issue, we might need to rename the linux artifact based on the version of Ubuntu.

image

Can you explain? This has worked until now.

@jonathanlinat
Copy link
Contributor Author

jonathanlinat commented Jan 31, 2024

Regarding this issue, we might need to rename the linux artifact based on the version of Ubuntu.
image

Can you explain? This has worked until now.

Sure!

I had to update the tool this project uses to send files to GitHub, and I think the way it names files changed too.

You can see that the file made for Ubuntu 22.04 was sent before the one for Ubuntu 20.04. But no matter which version of Ubuntu it used, both files ended up with the name linux.

image

This is causing a problem because there's already an uploaded file named linux, and it won't let it upload another one with the same name.

To fix this, the names of the files need to be changed to include the Ubuntu version they're for, like linux-20.04 and linux-22.04. We might also only need to tweak the settings of the action. I have to investigate that.

Do you want me to address this issue in this current PR or do you prefer I address it in another one?

@jonathanlinat
Copy link
Contributor Author

It is important to note that this specific action must be upgraded to Node 20.

image

@kduske I have created a PR to address this specific case: TrenchBroom/clean-commit-action#1

Once the PR is merged, I must update the current TrenchBroom GitHub Actions workflow(s) to upgrade the corresponding action to version 0.8.0.

Another important thing is I need you to manually create a tag to use the latest version of clean-commit-action. The tag must be named v0.8.0. I don't have the permission to proceed in this repository.

Screenshot from 2024-01-31 18-03-48

Screenshot from 2024-01-31 18-02-45

Screenshot from 2024-01-31 18-00-58

@kduske
Copy link
Collaborator

kduske commented Feb 1, 2024

I see. It would be better to address this in this PR before the action gets updated. These files must already be renamed when we publish a release, because they have much more prescriptive names then. Maybe we could just move that existing renaming step to before the file gets uploaded?

@kduske
Copy link
Collaborator

kduske commented Feb 2, 2024

I have created the v0.8.0 tag in https://github.com/TrenchBroom/clean-commit-action/tags

@jonathanlinat
Copy link
Contributor Author

Something's not working properly with the new version of clean-commit-action. I'll take a look.

…tibility' of github-personal:jonathanlinat/TrenchBroom into chore/upgrade_external_github_actions_for_node_20_compatibility
@jonathanlinat
Copy link
Contributor Author

jonathanlinat commented Feb 5, 2024

Something's not working properly with the new version of clean-commit-action. I'll take a look.

@kduske This PR is designed to address the malfunction in the clean-commit-action: https://github.com/TrenchBroom/clean-commit-action/pull/2/files

I cannot guarantee that it will work before merging the PR. We will figure it out after merging it.

Important: Please note that once it's merged, a new tag, v0.8.1, needs to be created.


To resolve the problem with a Linux artifact that was previously uploaded, the artifacts have been renamed according to the following convention:

image

The workflow does not fail anymore, and the artifacts are correctly uploaded.

image

@jonathanlinat
Copy link
Contributor Author

Just an additional thought.

Personally, I feel it would be wise to discontinue support for Windows (x32). It seems to me that not many mappers are using such an outdated architecture these days.

@kduske
Copy link
Collaborator

kduske commented Feb 5, 2024

Thanks, I have created the tag!

@jonathanlinat
Copy link
Contributor Author

jonathanlinat commented Feb 5, 2024

@kduske My apologies. I completely overlooked running the ./build.sh command in my Terminal, and as a result, the same problem occurred in the pipeline because of an unupdated dist file.

Here's the PR that should definitely fix this issue: TrenchBroom/clean-commit-action#3

Important: As noted in that PR, once it's merged, we'll need to create a new tag: v0.8.2

@kduske
Copy link
Collaborator

kduske commented Feb 5, 2024

Ok, I have created the release and deleted the other ones.

@jonathanlinat
Copy link
Contributor Author

jonathanlinat commented Feb 5, 2024

@kduske We're good now! 😃

@jonathanlinat jonathanlinat changed the title Upgrade external GitHub Actions actions (Node 20) ADHOC: Upgrade external GitHub Actions actions (Node 20) Feb 5, 2024
@jonathanlinat
Copy link
Contributor Author

jonathanlinat commented Feb 5, 2024

image

For those two issues, there is a pending PR ready to be merged in the corresponding repository.

However, to not block the merge of this current PR, I can create another one in the future once this action is updated: jurplel/install-qt-action#222

@kduske kduske changed the title ADHOC: Upgrade external GitHub Actions actions (Node 20) Upgrade external GitHub Actions actions (Node 20) Feb 5, 2024
@kduske kduske added this to the 2023.2 milestone Feb 5, 2024
@kduske kduske merged commit 3f5ad1f into TrenchBroom:master Feb 5, 2024
12 checks passed
@jonathanlinat jonathanlinat deleted the chore/upgrade_external_github_actions_for_node_20_compatibility branch February 7, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants