Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js version to 20; update CI dependencies to remove warnings #222

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

pzhlkj6612
Copy link
Contributor

This PR completes #219 and fixes #220 .

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/setup-python@v4, ./action. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@pzhlkj6612 pzhlkj6612 changed the title Update node.js version to 18; update CI dependencies to remove warnings Update node.js version to 20; update CI dependencies to remove warnings Jan 28, 2024
@MehdiChinoune
Copy link
Contributor

CI shows many notes about node16, I think It's from https://github.com/jurplel/install-qt-action/blob/master/action/action.yml#L79

@pzhlkj6612
Copy link
Contributor Author

CI shows many notes about node16, I think It's from https://github.com/jurplel/install-qt-action/blob/master/action/action.yml#L79

Fixed.

@bcmhercun
Copy link

@jurplel

@jonathanlinat
Copy link

jonathanlinat commented Feb 5, 2024

@jurplel Hey! 👋🏻 Would you be able to merge this soon? TY!

@jurplel
Copy link
Owner

jurplel commented Feb 6, 2024

Thanks for the ping!

@jurplel jurplel merged commit 386bf2f into jurplel:master Feb 6, 2024
59 of 60 checks passed
@pzhlkj6612 pzhlkj6612 deleted the ci-node-ver branch February 10, 2024 04:07
@xavier2k6
Copy link

@jurplel Any plans to merge this in to v3 branch & release 3.3.1?

@jurplel
Copy link
Owner

jurplel commented Feb 16, 2024

Will do, there are some test failures on the v3 branch for some reason preventing immediate release

@dc6c
Copy link

dc6c commented Mar 12, 2024

It looks like the failure is because the installed tools are not in the path in some conditions. Compare the outputs of stage "Test installed tools" for the workflow case "test (ubuntu-22.04, false, true, true, cached)": successful master:

Path: /home/runner/work/install-qt-action/Qt/Tools/QtInstallerFramework/4.6/bin:/home/runner/work/install-qt-action/Qt/Tools/QtCreator/libexec/qtcreator/clang/bin:/home/runner/work/install-qt-action/Qt/Tools/QtCreator/lib/Qt/bin:/home/runner/work/install-qt-action/Qt/Tools/QtCreator/bin:/opt/hostedtoolcache/Python/3.11.8/x64/bin:/opt/hostedtoolcache/Python/3.11.8/x64:/opt/hostedtoolcache/node/20.11.0/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

and failing branch v3:

Path: /opt/hostedtoolcache/Python/3.11.8/x64/bin:/opt/hostedtoolcache/Python/3.11.8/x64:/opt/hostedtoolcache/node/20.11.0/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Node dependency issue
8 participants