Change post loop avatar to background image #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #4330 - Changes the author avatar on pages with the post loop to background images
|
This is hack in ghost admin which I'd rather not pass onto themes, this fix addresses the symptom (stretched images) rather than the cause (images are not square). The correct solution is to provide square cropping if/when users upload profile pictures. The same thing that happens when you upload a profile picture to Gravatar or, indeed, most websites with a concept of profile pictures. I think the workaround for now should be "crop your profile image before uploading" rather than polluting theme standards with a hack and seeing that spread into the wider ecosystem. Tracking this via TryGhost/Ghost#4333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs TryGhost/Ghost#4330