Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Inconsistent handling of profile picture aspect ratio #4330

Closed
ThisGuyCodes opened this issue Oct 23, 2014 · 2 comments
Closed

Bug: Inconsistent handling of profile picture aspect ratio #4330

ThisGuyCodes opened this issue Oct 23, 2014 · 2 comments
Assignees

Comments

@ThisGuyCodes
Copy link

Issue Summary

In the author profile and at the head of each post, the aspect ratio of the uploaded picture is unchanged, but in list view and in the top bar of the admin area, the profile picture appears to be 'squarified' before the circle is cut.

Steps to Reproduce

  1. Upload a not-square profile picture
  2. Observe the difference between the smaller circle in the top right of the admin area, and in the 'edit user' area within the admin area (other locations listed above work, this shows them all in one place.

This is a bug because...
It's inconsistent behaviour. I don't actually know if this is a theme issue or not, but I thought the admin area was not part of themes, so let's stick with that specifically.

Here are two screenshots, first from the admin area, observe the bigger bottom left, and the smaller (squished) top right:
screen shot 2014-10-23 at 3 55 10 pm
And from the author posts-list page, a little bigger, but compage the top middle circle and the one next to the post name:
screen shot 2014-10-23 at 3 55 25 pm

Technical details

  • Ghost Version: master - latest commit: INSERT COMMIT REF
  • Client OS: OS X 10.9
  • Server OS: Ubuntu 14.04.1
  • Node Version: 0.10.25
  • Browser: Chrome 38.0.2125.104
  • Database: default (sqlite)
@PaulAdamDavis
Copy link
Member

Hi @conslo, thanks for the great bug report!

This bug exists because in some places we use <img> tags, and background images in other places. Hey should all be backgrounds to preserve the aspect ratio.

I'll do a PR to fix very soon.

@JohnONolan
Copy link
Member

This will be addressed in #4333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants