-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is sudo used in the uninstall command? #577
Comments
The reason sudo is used is because, by default in production, an additional I can update that check there to also check if the content folder is actually owned by the ghost user, but if it is owned by the ghost user there's no way to run What, specifically, is your use case for automating uninstalls? |
@acburdine thanks for the clarification! Using sudo in the default case (production) makes sense to me. Though, I do prefer your idea of detecting the ownership of the directory as a condition of using sudo. Our use case is not well defined, but we're experimenting with a developer kit for developing multiple Ghost projects. Our developers would all be FWIW, here's some throw away code I wrote while exploring the issue that compares ownership. broco1974@06fe197 |
Makes sense. |
closes TryGhost#577 - cleanup uninstall tests - disable remove content folder step if ghost user doesn't own content folder
closes TryGhost#577 - cleanup uninstall tests - disable remove content folder step if ghost user doesn't own content folder
closes #577 - cleanup uninstall tests - disable remove content folder step if ghost user doesn't own content folder
This makes it not possible to automate uninstall if the user does not have or need sudo.
If it is necessary, should there be a option to not use sudo?
ghost uninstall --no-sudo
Ghost-CLI/lib/commands/uninstall.js
Lines 46 to 48 in dd5d224
The text was updated successfully, but these errors were encountered: