Why is sudo used in the uninstall command?

[travismiller]

This makes it not possible to automate uninstall if the user does not have or need sudo.

If it is necessary, should there be a option to not use sudo? ghost uninstall --no-sudo

Ghost-CLI/lib/commands/uninstall.js

Lines 46 to 48 in dd5d224

	if (os.platform() === 'linux') {
	return this.ui.sudo(`rm -rf ${contentDir}`);
	}

[acburdine]

The reason sudo is used is because, by default in production, an additional ghost user is created to run the Ghost server process. That user is then made owner of the content folder. Hence during uninstall, sudo is required to remove that content folder.

I can update that check there to also check if the content folder is actually owned by the ghost user, but if it is owned by the ghost user there's no way to run uninstall completely without sudo.

What, specifically, is your use case for automating uninstalls?

[acburdine]

@travismiller ^

[travismiller]

@acburdine thanks for the clarification!

Using sudo in the default case (production) makes sense to me. Though, I do prefer your idea of detecting the ownership of the directory as a condition of using sudo.

Our use case is not well defined, but we're experimenting with a developer kit for developing multiple Ghost projects. Our developers would all be darwin and would not encounter this anyway.

FWIW, here's some throw away code I wrote while exploring the issue that compares ownership. broco1974@06fe197

[acburdine]

Makes sense.