Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uninstall): only use sudo to remove content folder when needed #634

Merged
merged 1 commit into from
Feb 7, 2018
Merged

fix(uninstall): only use sudo to remove content folder when needed #634

merged 1 commit into from
Feb 7, 2018

Conversation

acburdine
Copy link
Member

closes #577

  • cleanup uninstall tests
  • disable remove content folder step if ghost user doesn't own content folder

@acburdine
fix(uninstall): only use sudo to remove content folder when needed
ba98e71 
closes TryGhost#577
- cleanup uninstall tests
- disable remove content folder step if ghost user doesn't own content folder
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ba98e71 on acburdine:fix/uninstall-sudo into 5ae264f on TryGhost:master.

aileen
aileen approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@aileen aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aileen aileen merged commit 5e386d2 into TryGhost:master Feb 7, 2018
@acburdine acburdine deleted the fix/uninstall-sudo branch February 7, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aileen aileen aileen approved these changes

@kirrg001 kirrg001 Awaiting requested review from kirrg001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is sudo used in the uninstall command?
3 participants
@acburdine @coveralls @aileen