-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise error messages #587
Comments
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - first step on attaching original error properties to `CliError`
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - first step on attaching original error properties to `CliError`
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode - Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode - Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode - Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode - Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
refs #587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode - Adds `err` property with original error wherever we have it so it'll be passed along and printed in the log file
refs TryGhost#587 - fixes an issue, where failed requests with `got` wouldn't get catched properly - differentiates between `ProcessError` for `stderr` and `CliError` for everything else - `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode - Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
refs TryGhost#587 Instead of returning an error in the `get-uid` util we can simplify it and just return null. Explanation: Possible reasons for error: - Command is not known by OS or - User doesn't exist The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
refs TryGhost#587 Instead of returning an error in the `get-uid` util we can simplify it and just return null. Explanation: Possible reasons for error: - Command is not known by OS or - User doesn't exist The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
refs TryGhost#587 Instead of returning an error in the `get-uid` util we can simplify it and just return null. Explanation: Possible reasons for error: - Command is not known by OS or - User doesn't exist The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
refs #587 Instead of returning an error in the `get-uid` util we can simplify it and just return null. Explanation: Possible reasons for error: - Command is not known by OS or - User doesn't exist The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
refs TryGhost#681 refs TryGhost#587 Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
refs TryGhost#681 refs TryGhost#587 Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
…ost#702) refs TryGhost#681 refs TryGhost#587 Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
Our bot has automatically marked this issue as stale because there has not been any activity here in some time. The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR. We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂 |
This issue lists all the places where we have to optimise the error message.
{ Error: EACCES: permission denied, rmdir '/tmp/acme.sh/Neilpang-acme.sh-b6c2fc5/.github' at Error (native) errno: -13, code: 'EACCES', syscall: 'rmdir', path: '/tmp/acme.sh/Neilpang-acme.sh-b6c2fc5/.github' }
- you can use this as mock (!). This is just one example case. The error handler should be able to take custom properties into account!Edit Aileen:
Tasks:
ProcessError
so it can deal with custom propertiesThe text was updated successfully, but these errors were encountered: