Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise error messages #587

Closed
1 of 4 tasks
kirrg001 opened this issue Jan 16, 2018 · 1 comment
Closed
1 of 4 tasks

Optimise error messages #587

kirrg001 opened this issue Jan 16, 2018 · 1 comment
Assignees
@aileen
Labels
enhancement recommended-stack Stale

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Jan 16, 2018 •
edited by aileen
Loading

This issue lists all the places where we have to optimise the error message.

  • https://github.com/TryGhost/Ghost-CLI/blob/1.4.2/extensions/nginx/acme.js#L52 - if i am running into an error here, the error properties from the original error are not taken into account and it shows me a too generic message ({ Error: EACCES: permission denied, rmdir '/tmp/acme.sh/Neilpang-acme.sh-b6c2fc5/.github' at Error (native) errno: -13, code: 'EACCES', syscall: 'rmdir', path: '/tmp/acme.sh/Neilpang-acme.sh-b6c2fc5/.github' } - you can use this as mock (!). This is just one example case. The error handler should be able to take custom properties into account!

Edit Aileen:

Tasks:

  • error handling extensions (missing catches, better error messages)
  • error handling core (missing catches, better error messages)
  • improve ProcessError so it can deal with custom properties
@kirrg001 kirrg001 mentioned this issue Jan 19, 2018
Closed
aileen added a commit to aileen/Ghost-CLI that referenced this issue Jan 24, 2018
@aileen
feat(ssl) improve error messages for acme
a2051c1 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- first step on attaching original error properties to `CliError`
@aileen aileen mentioned this issue Jan 24, 2018
Merged
aileen added a commit to aileen/Ghost-CLI that referenced this issue Jan 24, 2018
@aileen
feat(ssl) improve error messages for acme
f0486aa 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- first step on attaching original error properties to `CliError`
aileen added a commit to aileen/Ghost-CLI that referenced this issue Jan 25, 2018
@aileen
feat(ssl) improve error messages to log orignal error
0cc6821 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
aileen added a commit to aileen/Ghost-CLI that referenced this issue Jan 25, 2018
@aileen
feat(ssl) improve error messages to log orignal error
83da6b2 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
- Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
aileen added a commit to aileen/Ghost-CLI that referenced this issue Jan 25, 2018
@aileen
feat(ssl) improve error messages to log original error
597f67d 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
- Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
aileen added a commit to aileen/Ghost-CLI that referenced this issue Jan 25, 2018
@aileen
feat(ssl) improve error messages to log original error
154c4c3 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
- Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 2, 2018
@aileen
feat(ssl) improve error messages to log original error
aecb1c9 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
- Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
acburdine pushed a commit that referenced this issue Feb 2, 2018
@aileen @acburdine
feat(ssl): improve error messages to log original error (#595)
509aa5a 
refs #587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
- Adds `err` property with original error wherever we have it so it'll be passed along and printed in the log file
kirrg001 pushed a commit to kirrg001/Ghost-CLI that referenced this issue Feb 2, 2018
@aileen @kirrg001
feat(ssl) improve error messages to log original error
7f5c266 
refs TryGhost#587

- fixes an issue, where failed requests with `got` wouldn't get catched properly
- differentiates between `ProcessError` for `stderr` and `CliError` for everything else
- `CliError` can be passed the original error and will log the `message` and `stack` to the log file, or log in the UI when in verbose mode
- Adds `err` property with original error whereever we have it so it'll be passed along and printed in the log file
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 7, 2018
@aileen
chore(mysql): improve error messages
405acc0 
refs TryGhost#587
@aileen aileen mentioned this issue Feb 7, 2018
Merged
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 15, 2018
@aileen
chore(mysql): improve error messages
9528c5e 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 15, 2018
@aileen
chore(nginx): improve error handling
84b28c3 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 15, 2018
@aileen
chore(systemd): improve error handling
e983897 
refs TryGhost#587
@aileen aileen mentioned this issue Feb 20, 2018
Closed
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 21, 2018
@aileen
chore(mysql): improve error messages
b363fb9 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 21, 2018
@aileen
chore(nginx): improve error handling
7e7a203 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 21, 2018
@aileen
chore(systemd): improve error handling
5dd90f9 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 22, 2018
@aileen
chore(mysql): improve error messages
4fdd13f 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 22, 2018
@aileen
chore(nginx): improve error handling
60f484e 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 22, 2018
@aileen
chore(systemd): improve error handling
83f22bd 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Feb 22, 2018
@aileen
chore(systemd): improve error handling
c3e825c 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 15, 2018
@aileen
chore(mysql): improve error messages
245c876 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 15, 2018
@aileen
chore(nginx): improve error handling
f19d728 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 15, 2018
@aileen
chore(systemd): improve error handling
0c32d49 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 16, 2018
@aileen
chore(systemd): ignore error in get-uid and return null
ee51d3d 
refs TryGhost#587

Instead of returning an error in the `get-uid` util we can simplify it and just return null.

Explanation:

Possible reasons for error:
- Command is not known by OS or
- User doesn't exist

The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 19, 2018
@aileen
chore(systemd): ignore error in get-uid and return null
29d7c54 
refs TryGhost#587

Instead of returning an error in the `get-uid` util we can simplify it and just return null.

Explanation:

Possible reasons for error:
- Command is not known by OS or
- User doesn't exist

The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 26, 2018
@aileen
chore(mysql): improve error messages
d57a98e 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 26, 2018
@aileen
chore(nginx): improve error handling
619a250 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 26, 2018
@aileen
chore(systemd): improve error handling
970a1bf 
refs TryGhost#587
aileen added a commit to aileen/Ghost-CLI that referenced this issue Mar 26, 2018
@aileen
chore(systemd): ignore error in get-uid and return null
8b6920a 
refs TryGhost#587

Instead of returning an error in the `get-uid` util we can simplify it and just return null.

Explanation:

Possible reasons for error:
- Command is not known by OS or
- User doesn't exist

The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
acburdine pushed a commit that referenced this issue Mar 26, 2018
@aileen @acburdine
chore(mysql): improve error messages
8b2ecb7 
refs #587
acburdine pushed a commit that referenced this issue Mar 26, 2018
@aileen @acburdine
chore(nginx): improve error handling
976bfcb 
refs #587
acburdine pushed a commit that referenced this issue Mar 26, 2018
@aileen @acburdine
chore(systemd): improve error handling
62ee92f 
refs #587
acburdine pushed a commit that referenced this issue Mar 26, 2018
@aileen @acburdine
chore(systemd): ignore error in get-uid and return null
1ea1759 
refs #587

Instead of returning an error in the `get-uid` util we can simplify it and just return null.

Explanation:

Possible reasons for error:
- Command is not known by OS or
- User doesn't exist

The first case is not very likely to happen, as systemd is never setup on a Windows. And the second case would exactly be the result we want. false if the user doesn't exist.
aileen added a commit to aileen/Ghost-CLI that referenced this issue Apr 11, 2018
@aileen
chore(utils): improve error message for incompatible ghost zip
d1f7345 
refs TryGhost#681
refs TryGhost#587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
@aileen aileen mentioned this issue Apr 11, 2018
Merged
aileen added a commit to aileen/Ghost-CLI that referenced this issue Apr 11, 2018
@aileen
chore(utils): improve error message for incompatible ghost zip
3169dba 
refs TryGhost#681
refs TryGhost#587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
kirrg001 pushed a commit that referenced this issue Apr 11, 2018
@aileen @kirrg001
chore(utils): improve error message for incompatible ghost zip (#702)
3a77ec8 
refs #681
refs #587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
vikaspotluri123 pushed a commit to vikaspotluri123/Ghost-CLI that referenced this issue Apr 25, 2018
@aileen @vikaspotluri123
chore(utils): improve error message for incompatible ghost zip (TryGh…
e830ebf 
…ost#702)

refs TryGhost#681
refs TryGhost#587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
@aileen aileen mentioned this issue May 4, 2018
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented May 3, 2021

Our bot has automatically marked this issue as stale because there has not been any activity here in some time. The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR. We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

@github-actions github-actions bot added the Stale label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aileen aileen

Labels
enhancement recommended-stack Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirrg001 @aileen