Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure content/settings folder #681

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

aileen
Copy link
Member

@aileen aileen commented Mar 21, 2018

refs TryGhost/Ghost#9528

  • adds content/settings folder to install process (for new installations)
  • adds a core migration that makes sure, content/settings exists (for older installations)

Todos:

  • create default routes.yaml file on install and migration. Question: where to get the default values from?
  • make sure it works fine with the Ghost changes
  • define the version for the migration

@coveralls
Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 9788651 on AileenCGN:feat/content-settings into f9c6711 on TryGhost:master.

@kirrg001
Copy link
Contributor

kirrg001 commented Apr 5, 2018

@acburdine

It would be good to ship this asap. When is the next release planned?
It will ensure that the content folder get's a new sub folder.

And if we have released this, we can then release TryGhost/Ghost#9534 with a new CLI engine bump in Ghost.

Currently we throw

Zip file contains a Ghost version incompatible with this version of the CLI.

Would be great to extend this error a bit and tell the user what todo cc @AileenCGN.

@kirrg001
Copy link
Contributor

kirrg001 commented Apr 6, 2018

@AileenCGN Why is this on HOLD?

create default routes.yaml file on install and migration. Question: where to get the default values from?

No.

define the version for the migration

@acburdine

@aileen aileen changed the title [HOLD] Ensure content/settings folder Ensure content/settings folder Apr 7, 2018
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - will test locally real quick

@aileen
Copy link
Member Author

aileen commented Apr 10, 2018

@acburdine Version is now set to 1.7.0

@acburdine
Copy link
Member

Works - thanks @AileenCGN 😄

@acburdine acburdine merged commit 1d562e7 into TryGhost:master Apr 10, 2018
aileen added a commit to aileen/Ghost-CLI that referenced this pull request Apr 11, 2018
refs TryGhost#681
refs TryGhost#587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
aileen added a commit to aileen/Ghost-CLI that referenced this pull request Apr 11, 2018
refs TryGhost#681
refs TryGhost#587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
kirrg001 pushed a commit that referenced this pull request Apr 11, 2018
refs #681
refs #587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
aileen added a commit to aileen/Ghost that referenced this pull request Apr 14, 2018
refs TryGhost#9528
refs TryGhost/Ghost-CLI#681

- added a new `/content/settings` folder
- bumped Ghost-CLI engine requirement to >= 1.7.0
kirrg001 pushed a commit to TryGhost/Ghost that referenced this pull request Apr 15, 2018
refs #9528
refs TryGhost/Ghost-CLI#681

- added a new `/content/settings` folder
- bumped Ghost-CLI engine requirement to >= 1.7.0
vikaspotluri123 pushed a commit to vikaspotluri123/Ghost-CLI that referenced this pull request Apr 25, 2018
…ost#702)

refs TryGhost#681
refs TryGhost#587

Give the user more information why the installation of the zip file failed. Renders the required and the current installed CLI version and the command to run to solve the issue.
@aileen aileen deleted the feat/content-settings branch May 10, 2018 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants