Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nav bar avatar to background image #4331

Closed
wants to merge 1 commit into from
Closed

Change nav bar avatar to background image #4331

wants to merge 1 commit into from

Conversation

PaulAdamDavis
Copy link
Member

Refs #4330

  • Changes the nav bar avatar from an <img> tag to a background-image

@PaulAdamDavis
Copy link
Member Author

Labeled as [WIP] because I'd like to know of I've done this right in Ember.

@novaugust
Copy link
Contributor

Sadly, I think you have :D I can't wait for html bars, when we won't need bind-attr

novaugust
novaugust reviewed Oct 24, 2014
View reviewed changes
core/client/templates/-navbar.hbs
{{else}}
<div class="image"><img src="/shared/img/user-image.png" alt="Profile picture" /></div>
<div class="image" style="background-image: ur(/shared/img/user-image.png);">

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@PaulAdamDavis PaulAdamDavis changed the title [WIP] Change nav bar avatar to background image Change nav bar avatar to background image Oct 27, 2014
@PaulAdamDavis
Change nav bar avatar to background image
173cfbe 
Refs #4330

- Changes the nav bar avatar from an `<img>` tag to a `background-image`
@novaugust
Copy link
Contributor

Code LGTM

@JohnONolan
Copy link
Member

Again, rather not merge something that will need to be reverted later - address in #4333

@JohnONolan JohnONolan closed this Oct 27, 2014
@ThisGuyCodes
Copy link

while I agree #4333 is the real solution to this, shouldn't the way it's used in the front end still be consistent?

@grnd grnd mentioned this pull request Mar 7, 2021
Open
This was referenced Mar 23, 2022
Open
Open
@amgir amgir mentioned this pull request May 13, 2024
Open
@mdno mdno mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PaulAdamDavis @novaugust @JohnONolan @ThisGuyCodes @jaswilli