Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Not redirected to sign-in with invalid session #6047

Closed
kevinansfield opened this issue Nov 5, 2015 · 1 comment · Fixed by #6061
Closed

Regression: Not redirected to sign-in with invalid session #6047

kevinansfield opened this issue Nov 5, 2015 · 1 comment · Fixed by #6061
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly P2 - High [triage] High priority for immediate patch release

Comments

@kevinansfield
Copy link
Member

Steps to reproduce:

  1. Sign-in to your current dev install
  2. Delete your database
  3. Re-start the dev server
  4. Try to navigate through the app

Expected result: You are redirected to /signin

Actual result: You are shown the "Error" page and the console contains the 401 unauthorised response error followed by 1 or more Adapter operation failed errors.
@kevinansfield kevinansfield added bug [triage] something behaving unexpectedly affects:admin Anything relating to Ghost Admin P2 - High [triage] High priority for immediate patch release labels Nov 5, 2015
@kevinansfield kevinansfield mentioned this issue Nov 5, 2015
Closed
@kevinansfield kevinansfield changed the title Bug: Not redirected to sign-in with invalid session Regression: Not redirected to sign-in with invalid session Nov 5, 2015
@kevinansfield kevinansfield self-assigned this Nov 5, 2015
@kevinansfield
Copy link
Member Author

The fix for this should fall out of the work outlined in #6048 (comment)

kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Nov 6, 2015
@kevinansfield
add failing tests for TryGhost#6047 & TryGhost#6048
020c55e
@kevinansfield kevinansfield mentioned this issue Nov 6, 2015
Closed
6 tasks
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Nov 6, 2015
@kevinansfield
add failing tests for TryGhost#6047 & TryGhost#6048
f66a612
@kevinansfield kevinansfield mentioned this issue Nov 10, 2015
Merged
@ErisDS ErisDS mentioned this issue Nov 10, 2015
Closed
7 tasks
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Nov 12, 2015
@kevinansfield
Fix auth regressions after ESA 1.0 upgrade
73ea9f5 
refs TryGhost#6039, closes TryGhost#6047, closes TryGhost#6048

- delete old/unused fixtures file
- add failing tests for TryGhost#6047 & TryGhost#6048
- redirect to sign-in if we get a 401 when making an API request
- fix incorrect `this.notifications` call in tag controller
- raise `authorizationFailed` action in application route's `sessionInvalidated` hook so that it can be handled by leaf routes (fixes re-auth modal display)
- close "saving failed" alert when successfully re-authenticated
- adds a "window-proxy" util so that we can override `window.*` operations in tests
- fix `gh-selectize` attempting to register event handlers when the component has already been destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly P2 - High [triage] High priority for immediate patch release
Projects
None yet
Milestone
No milestone
1 participant
@kevinansfield