Fix auth regressions after ESA 1.0 upgrade #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this out and it's looking good, just got a couple of linter issues. |
kevinansfield
force-pushed
the
fix-auth-regressions
branch
2 times, most recently
from
6f18c6f
to
3d45730
Compare
|
Interesting - This is passing locally using phantomjs 2 but failing on Travis with 1.9. I'll try downgrading to see if I can replicate. |
refs TryGhost#6039, closes TryGhost#6047, closes TryGhost#6048 - delete old/unused fixtures file - add failing tests for TryGhost#6047 & TryGhost#6048 - redirect to sign-in if we get a 401 when making an API request - fix incorrect `this.notifications` call in tag controller - raise `authorizationFailed` action in application route's `sessionInvalidated` hook so that it can be handled by leaf routes (fixes re-auth modal display) - close "saving failed" alert when successfully re-authenticated - adds a "window-proxy" util so that we can override `window.*` operations in tests - fix `gh-selectize` attempting to register event handlers when the component has already been destroyed
kevinansfield
force-pushed
the
fix-auth-regressions
branch
from
3d45730
to
73ea9f5
Compare
|
All green now 😄 |
ErisDS
added a commit
that referenced
this pull request
Nov 12, 2015
Fix auth regressions after ESA 1.0 upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6039, closes #6047, closes #6048
this.notificationscall in tag controllerauthorizationFailedaction in application route'ssessionInvalidatedhook so that it can be handled by leaf routes (fixes re-auth modal display)gh-selectizeattempting to register event handlers when the component has already been destroyed