forked from scratchfoundation/scratch-blocks
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom blocks to return values - blocks part #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with "item of list"
This reverts commit 730b8f33819653cf8cd95e0cf1e714b709fbfcac.
If all return statements in a procedure definition contain a hexagon-shaped block, the call block for that procedure will itself become hexagon shaped.
We store information about every procedure before the change happens, then diff it later. Should improve performance.
…call types Blockly.Procedures.USER_CAN_CHANGE_CALL_TYPE: `true` is the behavior for TurboWarp `false` will restore behavior from two commits ago
Blockly.Procedures.ENFORCE_TYPES: I currently intend to have this set to `false` for TurboWarp You can set it to `true` for the old behavior.
In TW we will make this an "extension" for people to enable. The return block will be hidden until that extension is enabled, or a return block or non-statement shaped procedure call exists in the workspace. There is a constant to restore the previous behavior.
Let's actually try to explain what this does. Also serves as a separator and makes it clear return is not a normal block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.