Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom blocks to return values - blocks part #3

Merged
merged 26 commits into from
Jul 29, 2023
Merged

Allow custom blocks to return values - blocks part #3

merged 26 commits into from
Jul 29, 2023

Commits on Jul 2, 2023

  1. Add warning to default_toolbox.js

    @GarboMuffin
    GarboMuffin committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    4b14dea View commit details
    Browse the repository at this point in the history

  2. Refresh toolbox when loading XML in playground

    @GarboMuffin
    GarboMuffin committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    af31811 View commit details
    Browse the repository at this point in the history

  3. Implement procedure returns

    @GarboMuffin
    GarboMuffin committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    1f1cdcc View commit details
    Browse the repository at this point in the history

  4. Don't save return in mutation if it's default value

    @GarboMuffin
    GarboMuffin committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d241e10 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Fix editing a procedure corrupting the project

    @GarboMuffin
    GarboMuffin committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    5badb50 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Update shape of loose blocks when return types change

    @GarboMuffin
    GarboMuffin committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ed976a5 View commit details
    Browse the repository at this point in the history

  2. Allow custom reporters to be dropped into boolean inputs 

    This is consistent with "item of list"
    @GarboMuffin
    GarboMuffin committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bdf1873 View commit details
    Browse the repository at this point in the history

  3. Do not show return block if no custom blocks exist

    @GarboMuffin
    GarboMuffin committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9e6acb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Revert "Allow custom reporters to be dropped into boolean inputs" 

    This reverts commit 730b8f33819653cf8cd95e0cf1e714b709fbfcac.
    @Wowfunhappy @GarboMuffin
    Wowfunhappy authored and GarboMuffin committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    009dc40 View commit details
    Browse the repository at this point in the history

  2. Allow custom boolean reporters 

    If all return statements in a procedure definition contain a hexagon-shaped block, the call block for that procedure will itself become hexagon shaped.
    @Wowfunhappy @GarboMuffin
    Wowfunhappy authored and GarboMuffin committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3e38f3e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from Wowfunhappy/return

    @GarboMuffin
    GarboMuffin authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8fa219d View commit details
    Browse the repository at this point in the history

  4. Style nitpicks

    @GarboMuffin
    GarboMuffin committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1a9ffe5 View commit details
    Browse the repository at this point in the history

  5. Don't add extra padding to right side of custom reporters

    @GarboMuffin
    GarboMuffin committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3f38dfa View commit details
    Browse the repository at this point in the history

  6. Fix editor crash when custom reporter has an empty proccode

    @GarboMuffin
    GarboMuffin committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2ad1fd8 View commit details
    Browse the repository at this point in the history

  7. Simplify some logic in flyoutCategory

    @GarboMuffin
    GarboMuffin committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    89577eb View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Only refresh toolbox when procedure returns actually changed 

    We store information about every procedure before the change happens,
then diff it later. Should improve performance.
    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    8450c3b View commit details
    Browse the repository at this point in the history

  2. Only change call block shape when definition shape actually changed

    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cec307b View commit details
    Browse the repository at this point in the history

  3. Add a variable to configure whether user is able to modify procedure … 

    …call types

Blockly.Procedures.USER_CAN_CHANGE_CALL_TYPE:
`true` is the behavior for TurboWarp
`false` will restore behavior from two commits ago
    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    75121c4 View commit details
    Browse the repository at this point in the history

  4. Hide options to change procedure call shape when USER_CAN_CHANGE_CALL… 

    …_TYPE is false
    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    2ea6a04 View commit details
    Browse the repository at this point in the history

  5. Improve boolean support in "Change to reporter" context menu item

    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    274321f View commit details
    Browse the repository at this point in the history

  6. Add option to allow dropping procedure calls anywhere again 

    Blockly.Procedures.ENFORCE_TYPES:
I currently intend to have this set to `false` for TurboWarp
You can set it to `true` for the old behavior.
    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f8c6271 View commit details
    Browse the repository at this point in the history

  7. Fix procedure call type being lost when proccode changes

    @GarboMuffin
    GarboMuffin committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    fb2b5fd View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Fix error when connecting procedure definition block

    @GarboMuffin
    GarboMuffin committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    44019ce View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Do not list return block in toolbox unless enabled 

    In TW we will make this an "extension" for people to enable.
The return block will be hidden until that extension is enabled, or a
return block or non-statement shaped procedure call exists in the workspace.

There is a constant to restore the previous behavior.
    @GarboMuffin
    GarboMuffin committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    9b7be14 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Don't show option to change reporter type if returns aren't enabled

    @GarboMuffin
    GarboMuffin committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    cfaa20b View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Add button explaining how to use return 

    Let's actually try to explain what this does.
Also serves as a separator and makes it clear return is not a normal block
    @GarboMuffin
    GarboMuffin committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    1d71d94 View commit details
    Browse the repository at this point in the history