-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC find_good_eps
#27
Milestone
Comments
5 tasks
I refactored it anyway (in 6cd458d) but I don't see any reason we have to drop the dependency any more. Plus it still depends on |
xukai92
added a commit
that referenced
this issue
Jul 6, 2019
xukai92
added a commit
that referenced
this issue
Jul 10, 2019
* Initial design for new `Trajectory` and `Termination` types. * fix some type definitions * rename NUTS_Termination to NoUTurnTermination * introduce DoublingTree type * fix RFC typo * initial DoublingTree impl * add a isUturn function * add a comment * improve NUTS type * improve abstraction * bugfix for MH step and add more comments (#75) * draft a docstring for the sample function (#75) * RFC find_good_eps (#27) and add some more comments (#75) * add some preparation code * indicate the numerical error location (#71) * Re-organise code to improve readability - no functionality change. * Re-organise code to improve readability - no functionality change. * remove replace sampling with samplerType * revert naming * improve test script * not use find_good_eps for precondition only adaptation * improve function names in tests * breaking change: passed-in grad function is now suppoed to return a tuple of value and gradient * bugfix * actually use the cache mechanism; almost 2x speed-up * add DiffResults to test deps * improve comments and naming * update packages in env * Code sytle updates - no functionality change. * Code sytle updates - no functionality change. * Unify `merge` function via kwargs - no functionality change. * Rename `sample` ==> `combine` - no functionality change. * Rename `merge` ==> `combine` - no functionality change. * Renamed `isUturn` ==> `isturn`, `iscontinued` ==> `isdivergent` - no functionality change. * Make `∂H∂θ(h, θ)` return `DualValue` istead of `Tuple`. * make rng the first argument of combine if used * update README.md * double sample numbers in test * Update README.md
Closed by PR #79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Copied from @yebai comment in #23 (comment)
out of
find_good_eps
and wrapinginto a function
Then, we can drop the dependency on
AdvancedHMC
from this function:find_good_eps(h::Hamiltonian, θ::AbstractVector{T}, A::Function; max_n_iters::Int=100)
, and move it intoadaption/stepsize.jl
.The text was updated successfully, but these errors were encountered: