Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get more comments and docstrings #75

Closed
xukai92 opened this issue Jun 11, 2019 · 1 comment
Closed

Get more comments and docstrings #75

xukai92 opened this issue Jun 11, 2019 · 1 comment
Milestone
Release v0.2

Comments

@xukai92
Copy link
Member

xukai92 commented Jun 11, 2019

No description provided.

@xukai92 xukai92 mentioned this issue Jul 6, 2019
Merged
5 tasks
xukai92 added a commit that referenced this issue Jul 6, 2019
@xukai92
bugfix for MH step and add more comments (#75)
fd4e79b
xukai92 added a commit that referenced this issue Jul 6, 2019
@xukai92
draft a docstring for (#75)
6d00b47
xukai92 added a commit that referenced this issue Jul 6, 2019
@xukai92
draft a docstring for the sample function (#75)
3c9140e
xukai92 added a commit that referenced this issue Jul 6, 2019
@xukai92
RFC find_good_eps (#27) and add some more comments (#75)
6cd458d
@xukai92 xukai92 added this to the Release v0.2 milestone Jul 9, 2019
xukai92 added a commit that referenced this issue Jul 10, 2019
@xukai92
[WIP] Support multinomial sampling for NUTS, and more (#79)
8cfe715 
* Initial design for new `Trajectory` and `Termination` types.

* fix some type definitions

* rename NUTS_Termination to NoUTurnTermination

* introduce DoublingTree type

* fix RFC typo

* initial DoublingTree impl

* add a isUturn function

* add a comment

* improve NUTS type

* improve abstraction

* bugfix for MH step and add more comments (#75)

* draft a docstring for the sample function (#75)

* RFC find_good_eps (#27) and add some more comments (#75)

* add some preparation code

* indicate the numerical error location (#71)

* Re-organise code to improve readability - no functionality change.

* Re-organise code to improve readability - no functionality change.

* remove replace sampling with samplerType

* revert naming

* improve test script

* not use find_good_eps for precondition only adaptation

* improve function names in tests

* breaking change: passed-in grad function is now suppoed to return a tuple of value and gradient

* bugfix

* actually use the cache mechanism; almost 2x speed-up

* add DiffResults to test deps

* improve comments and naming

* update packages in env

* Code sytle updates - no functionality change.

* Code sytle updates - no functionality change.

* Unify `merge` function via kwargs - no functionality change.

* Rename `sample` ==> `combine` - no functionality change.

* Rename `merge` ==> `combine` - no functionality change.

* Renamed `isUturn` ==> `isturn`, `iscontinued` ==> `isdivergent` - no functionality change.

* Make `∂H∂θ(h, θ)` return `DualValue` istead of `Tuple`.

* make rng the first argument of combine if used

* update README.md

* double sample numbers in test

* Update README.md
@xukai92
Copy link
Member Author

xukai92 commented Jul 10, 2019

Closed by PR #79.

@xukai92 xukai92 closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v0.2
Development

No branches or pull requests
1 participant
@xukai92